Added tests for link down consistency #339
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
italovalcy
reviewed
Dec 13, 2024
There was a problem hiding this comment.
Hi @Ktmi Excellent to see those new tests adding extra checks for the link failure handler process! One question please: one of the main problems that was address on PR mef_eline#583 was multiple link failures that would impact the old_path clean up process left over after the first failure, are those new tests also validating this? I'm asking this because it was not clear to me which test simulate multiple link failures after the EVC has been provisioned.
|
@italovalcy No, but I am planning on trying to make some additional tests for that purpose, it's just very difficult to get done consistently. |
viniarck
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests which validate consistency of kytos after link down events. Part of kytos-ng/mef_eline#583.