forked from kytos/kytos
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Dead letter structure for unhandled exceptions of KytosEvents indexed by their names #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added as_dict and as_json on KytosEvent
Added DeadLetter unit tests
viniarck
commented
Apr 12, 2022
Adapted max messages to 50k
listen_to
subscribed topics
ajoaoff
approved these changes
May 6, 2022
Thanks for reviewing, Antonio |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #197
This dead letter in-memory structure is meant to provide a mechanism of last resort to allow re-injection of failed KytosEvent when unhandled exception happens on a
listen_to
handler (for instance, maximum retries reached, full outage of async events or even unexpected ones). This is meant to ensure production-grade error handling for errors that are transient. So far we don't have a full blown message broker (yet), so this structure fills that gap, as long as thekytosd
is up an running it should be possible to list, reinject or delete these events. The underlying structure is anOrderedDict
instead of aQueue
to provide more flexibility when re-injecting and deleting arbitrary events.This PR is on top of PR #203 (to facilitate development)
Description of the change
Practical example
kytos/core.switch.new
andkytos/core.switch.reconnected
, if you list the endpoint, you'll see the events:kytos/core.switch.new
events on theapp
kytos queue buffer to all subscribers again (or you could also selectively specify the KytosEvent ids):reinjections
was incremented and it was reinjected on theapp
queue: