Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Send custom or empty peer list to client for private installs. #287

Closed
dan-da opened this issue Oct 10, 2017 · 1 comment
Closed

Comments

@dan-da
Copy link

dan-da commented Oct 10, 2017

Doing a private install for a non-technical customer. I want the electrum client to connect only to a single private (self-hosted) server. As such, there should be a mechanism to send either an empty peer list or a custom peer list. For now, all I really need is empty.

for now I achieved this by hacking coins.py and removing the peers, but hoping to get something better in place upstream as that change will be reverted the next time local install is upgraded.

Also, I will mention that is misleading/confusing when looking at the logs and it says eg:

INFO:PeerManager:accepted new peer 4/14 electrum.vom-stausee.de from coins.py

That seems to indicate that a peer connection was made. But apparently it only means that a local peer entry was created, with no connection attempt. I would suggest re-wording this, and/or adding a log entry that no peer discovery or connections will be made when PEER_DISCOVERY="".

This issue is essentially a +1 for issue #199 that was closed without resolution.

kyuupichan pushed a commit that referenced this issue Oct 11, 2017
It is now tri-state - ON, OFF or SELF.

Fixes #287
@dan-da
Copy link
Author

dan-da commented Oct 11, 2017

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant