Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sample policies to include more container types #953

Merged
merged 3 commits into from
May 15, 2024

Conversation

michaelkotelnikov
Copy link
Contributor

Related Issue(s)

Related to - #951

Description

Fixes the samples polices described in the issue.

Checklist

  • I have read the policy contribution guidelines.
  • [] I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended.
  • [] I have added the artifacthub-pkg.yml file and have verified it is complete and correct.

@michaelkotelnikov
Copy link
Contributor Author

@realshuting

Signed-off-by: michaelkot97 <michael.kot97@gmail.com>
@chipzoller
Copy link
Contributor

Thanks. Minimally, we need you to update the artifacthub-pkg.yml file for every policy you modified. Please see the contribution guide in the root of this repo for details.

Signed-off-by: michaelkot97 <michael.kot97@gmail.com>
@michaelkotelnikov
Copy link
Contributor Author

Thank you @chipzoller for pointing this out. Fixed now.

@realshuting realshuting requested a review from chipzoller March 26, 2024 22:57
Copy link
Contributor

@chipzoller chipzoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to include these additional container types in the automated Chainsaw tests.

@JimBugwadia JimBugwadia merged commit 7949c9e into kyverno:main May 15, 2024
144 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants