Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add other policies in CEL expressions - Part 2 #960

Merged
merged 29 commits into from
May 16, 2024
Merged

feat: add other policies in CEL expressions - Part 2 #960

merged 29 commits into from
May 16, 2024

Conversation

Chandan-DK
Copy link
Contributor

@Chandan-DK Chandan-DK commented Mar 30, 2024 •
edited

Related Issue(s)

Partially addresses #891

Description

This PR includes the conversion of policies in the other folder to Kyverno CEL policies. Conversion of the policies will be done in multiple PRs

Policies converted in this PR:

  • enforce-pod-duration
  • enforce-readwriteonce-pod
  • ensure-probes-different
  • ensure-readonly-hostpath
  • forbid-cpu-limits to cel
  • imagepullpolicy-always
  • ingress-host-match-tls
  • limit-containers-per-pod
  • limit-hostpath-type-pv

Checklist

  • [] I have read the policy contribution guidelines.
  • [] I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended.
  • [] I have added the artifacthub-pkg.yml file and have verified it is complete and correct.

@Chandan-DK
copy enforce-pod-duration
c2cd926 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
convert enforce-pod-duration to cel
4b8d07c 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
add CI test for directories starting with e to l in other-cel folder
2ba3e1c 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
copy enforce-readwriteonce-pod
e593e32 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
convert enforce-readwriteonce-pod to cel
c8b329a 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
copy ensure-probes-different
c743e24 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
convert ensure-probes-different to cel
3fb487b 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@MariamFahmy98 MariamFahmy98 self-assigned this Mar 31, 2024
@MariamFahmy98 MariamFahmy98 self-requested a review March 31, 2024 15:53
@Chandan-DK
copy forbid-cpu-limits
7df7c8f 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
convert forbid-cpu-limits to cel
c0a44b6 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
copy limit-containers-per-pod
bcd7bf3 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
convert limit-containers-per-pod to cel
e3b216e 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
copy pdb-maxunavailable
6e3ea37 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
convert pdb-maxunavailable to cel
bbc2c33 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
keep pdb-maxunavailable in a separate PR
84630b5 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
copy imagepullpolicy-always
18235cd 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
convert imagepullpolicy-always to cel
4b6c0a0 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
copy limit-hostpath-type-pv
c97304e 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
convert limit-hostpath-type-pv to cel
22509cb 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
copy ensure-readonly-hostpath
fc6223c 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
convert ensure-readonly-hostpath to cel
00115bb 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
copy ingress-host-match-tls
d47d9c1 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
convert ingress-host-match-tls to cel
dc33d14 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
rename files for clarity
19d396d 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK
add new lines at the end of files
2858638 
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@Chandan-DK Chandan-DK marked this pull request as ready for review April 6, 2024 18:04
MariamFahmy98
MariamFahmy98 reviewed Apr 22, 2024
View reviewed changes
Copy link
Contributor

@MariamFahmy98 MariamFahmy98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor comments.

other-cel/enforce-readwriteonce-pod/enforce-readwriteonce-pod.yaml Outdated Show resolved Hide resolved
other-cel/enforce-readwriteonce-pod/artifacthub-pkg.yml Outdated Show resolved Hide resolved
Chandan-DK and others added 2 commits April 22, 2024 18:35
@Chandan-DK @MariamFahmy98
update artifacthub-pkg.yml for enforce-readwriteonce-pod
af2936c 
Co-authored-by: Mariam Fahmy <mariamfahmy66@gmail.com>
Signed-off-by: Chandan-DK <chandandk468@gmail.com>
@MariamFahmy98
Merge branch 'main' into other-policies-cel-part-2
1fabcd7
MariamFahmy98
MariamFahmy98 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@MariamFahmy98 MariamFahmy98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MariamFahmy98
Copy link
Contributor

@Chandan-DK - Could you please resolve the conflicts?

@MariamFahmy98 MariamFahmy98 merged commit 7e55ff1 into kyverno:main May 16, 2024
163 of 164 checks passed
@Chandan-DK Chandan-DK deleted the other-policies-cel-part-2 branch June 7, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariamFahmy98 MariamFahmy98 MariamFahmy98 approved these changes

Assignees

@MariamFahmy98 MariamFahmy98

Labels
None yet
Projects
Good First Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Chandan-DK @MariamFahmy98