Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Helm Charts #13

Merged
merged 7 commits into from
Mar 16, 2021
Merged

Improve Helm Charts #13

merged 7 commits into from
Mar 16, 2021

Conversation

kolikons
Copy link
Contributor

Hi,
I'm a little bit improve your helm charts and added more options to values.yml

Also, I don't like the secret file, you don't encrypt to base64 and some CI can block when you're checking manifest
I'll recomend you replace https://github.com/kolikons/policy-reporter/blob/main/charts/policy-reporter/templates/targetssecret.yaml#L8 to data and use | b64enc but it's braking change i didn't want to do that right now

Implemented:

  1. Tolerance and nodeselect that's necessary in most of case
  2. Ingress for UI
  3. other stuff

what's affected:

  1. I replaced variable deployment.annotation to annotation
  2. I removed role because i don't see where that uses
  3. resources is empty by default

@fjogeleit
Copy link
Member

Hey, thanks for your contribution, I will check your changes but the Role is required for the runtime update of the priority config map: https://github.com/fjogeleit/policy-reporter/blob/main/pkg/kubernetes/config_map_adapter.go

@fjogeleit fjogeleit self-requested a review March 16, 2021 21:23
@fjogeleit fjogeleit added the enhancement New feature or request label Mar 16, 2021
Copy link
Member

@fjogeleit fjogeleit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I will update the documentation about your changes and release it tomorrow.

@fjogeleit fjogeleit merged commit 8c30dfd into kyverno:main Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants