Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add honorLabels setting #216

Merged
merged 1 commit into from
Oct 19, 2022
Merged

add honorLabels setting #216

merged 1 commit into from
Oct 19, 2022

Conversation

monotek
Copy link
Contributor

@monotek monotek commented Oct 18, 2022

Signed-off-by: André Bauer andre.bauer@staffbase.com

  • add honorLabels setting to monitoring chart
  • if set to true the labels from the exporter are used
  • false (current behaviour) means that "namespace" label would be scraped as "exported_namespace"

Imho default could be "true" too but that would need changes to the Grafana dashboards as well.

Signed-off-by: André Bauer <andre.bauer@staffbase.com>
@fjogeleit
Copy link
Member

Thanks for your contribution, you can ignore failures for the helm linting stage related to versions. I change them when I prepare the next release.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3277551150

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.646%

Totals Coverage Status
Change from base Build 3271602595: 0.0%
Covered Lines: 3730
Relevant Lines: 3941

💛 - Coveralls

@fjogeleit fjogeleit merged commit 9b7add6 into kyverno:main Oct 19, 2022
@monotek
Copy link
Contributor Author

monotek commented Oct 19, 2022

Hmm... looking at the github actions it seems the chart version 2.13.2 was not released?

https://github.com/kyverno/policy-reporter/actions/runs/3280256710/jobs/5400817748

Output of the release is: "Nothing to do. No chart changes detected."

Repo still has 2.13.1:

 helm search repo policy-reporter
NAME                                   	CHART VERSION	APP VERSION	DESCRIPTION                                       
kyverno-policy-reporter/policy-reporter	2.13.1       	2.10.1     	Policy Reporter watches for PolicyReport Resour...

@fjogeleit
Copy link
Member

I have to release it manually at the moment, but the release is running now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants