Add nameOverride to charts #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Micah Nagel <micah.nagel@defenseunicorns.com>
Signed-off-by: Micah Nagel <micah.nagel@defenseunicorns.com>
|
I think you need to update the Chart.lock file with |
Signed-off-by: Micah Nagel <micah.nagel@defenseunicorns.com>
|
@fjogeleit thanks! I wasn't sure if that was something done during PRs or not since I've seen different approaches. Updated and this should be good on the linting now. |
|
You're welcome, thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More context is provided in the issue this closes, but the goal is to provide a
nameOverrideto each chart that makes use of.Chart.Name. This value overrides the chart name anywhere it is used for labels/container names/etc.Fixes #253
Signed-off-by: Micah Nagel micah.nagel@defenseunicorns.com