Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use internal AWS credential loading as fallback #453

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

fjogeleit
Copy link
Member

@balonik this change should enable AWS to fallback to its internal credentials load logic when no static credentials nor web identity is used.

Signed-off-by: Frank Jogeleit <frank.jogeleit@lovoo.com>
@coveralls
Copy link

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 9512314476

Details

  • 5 of 6 (83.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 89.663%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/helper/aws.go 0 1 0.0%
Totals Coverage Status
Change from base Build 9489999285: 0.05%
Covered Lines: 5317
Relevant Lines: 5930

💛 - Coveralls

@fjogeleit fjogeleit merged commit a21564a into main Jun 14, 2024
3 checks passed
@fjogeleit fjogeleit deleted the aws-credentials branch June 14, 2024 07:31
@balonik
Copy link
Contributor

balonik commented Jun 14, 2024

@fjogeleit thanks! I will try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants