Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Slack channel override when using a secretRef for the webhook #460

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

jescarri
Copy link
Contributor

Related to: #458

Config file:

namespace: kyverno
slack:
  channels:
    - channel: kyverno-reports1
      customFields:
        cluster: ACluster
      filter:
        namespaces:
          include:
          - foo
          - bar
        policies:
          include:
          - testpolicy
        priorities:
          include: warning
      name: team1
      secretRef: kyverno-policy-reporter-data
      skipExistingOnStartup: false
      sources:
      - kyverno
    - channel: kyverno-reports2
      customFields:
        cluster: ACluster
      filter:
        namespaces:
          include:
          - tes1
        policies:
          include:
          - testPolicy
        priorities:
          include: warning
      name: team2
      secretRef: kyverno-policy-reporter-data
      skipExistingOnStartup: false
      sources:
      - kyverno

output

1.7207403643162174e+09	info	API BasicAuth enabled
1.7207403643356915e+09	info	team1 configured
1.7207403643685389e+09	info	team2 configured
1.7207403643687537e+09	info	start client	{"worker": 5}
1.7207403644691234e+09	info	informer sync completed
1.7207403647018857e+09	info	team1: PUSH OK
1.7207403647848663e+09	info	team2: PUSH OK
1.720740364784887e+09	info	team2: PUSH OK

Related to: kyverno#458

Signed-off-by: Jesus Carrillo <jesuscarrillo8@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9899859141

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 89.604%

Files with Coverage Reduction New Missed Lines %
pkg/config/target_factory.go 2 96.48%
Totals Coverage Status
Change from base Build 9870395492: -0.03%
Covered Lines: 5318
Relevant Lines: 5935

💛 - Coveralls

@fjogeleit fjogeleit merged commit 8d902f3 into kyverno:main Jul 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants