Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support runtime changes of target secretRefs #465

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Conversation

fjogeleit
Copy link
Member

No description provided.

Signed-off-by: Frank Jogeleit <frank.jogeleit@web.de>
Signed-off-by: Frank Jogeleit <frank.jogeleit@web.de>
@coveralls
Copy link

coveralls commented Jul 30, 2024

Pull Request Test Coverage Report for Build 10160891049

Details

  • 460 of 517 (88.97%) changed or added relevant lines in 12 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 85.37%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/config/resolver.go 18 20 90.0%
pkg/target/factory/factory.go 287 313 91.69%
pkg/kubernetes/secrets/informer.go 53 82 64.63%
Files with Coverage Reduction New Missed Lines %
pkg/listener/metrics/cache.go 2 93.18%
pkg/config/resolver.go 5 80.82%
Totals Coverage Status
Change from base Build 9791457985: 0.02%
Covered Lines: 6261
Relevant Lines: 7334

💛 - Coveralls

@fjogeleit fjogeleit force-pushed the target-runtime-updates branch 2 times, most recently from c663b73 to 4b8921a Compare July 30, 2024 09:56
Signed-off-by: Frank Jogeleit <frank.jogeleit@web.de>
@fjogeleit fjogeleit merged commit 65a0e04 into 3.x Jul 30, 2024
2 checks passed
@fjogeleit fjogeleit deleted the target-runtime-updates branch August 5, 2024 15:16
fjogeleit added a commit that referenced this pull request Sep 1, 2024
* Support runtime changes of target secretRefs

Signed-off-by: Frank Jogeleit <frank.jogeleit@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants