Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use resource version while watching #157

Merged
merged 4 commits into from
Jul 4, 2024
Merged

fix: use resource version while watching #157

merged 4 commits into from
Jul 4, 2024

Conversation

vishal-chdhry
Copy link
Member

No description provided.

Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 134 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (19dc442) to head (d5733ae).

Files Patch % Lines
pkg/api/cephr.go 0.00% 33 Missing ⚠️
pkg/api/cpolr.go 0.00% 33 Missing ⚠️
pkg/api/ephr.go 0.00% 33 Missing ⚠️
pkg/api/polr.go 0.00% 33 Missing ⚠️
pkg/api/filter.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main    #157    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files         30      30            
  Lines      17988   18098   +110     
======================================
- Misses     17988   18098   +110     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
@vishal-chdhry vishal-chdhry merged commit e28d413 into main Jul 4, 2024
21 checks passed
@vishal-chdhry vishal-chdhry deleted the watch-rv branch July 4, 2024 14:31
stone-z pushed a commit to giantswarm/reports-server-upstream that referenced this pull request Jul 4, 2024
* fix: use resource version while watching

Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>

* fix: dont append

Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>

* fix: deepcopy

Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>

* fix: wrong var

Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>

---------

Signed-off-by: Vishal Choudhary <vishal.choudhary@nirmata.com>
Signed-off-by: Zach Stone <zach@giantswarm.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant