Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier and namespace updates #3

Merged
merged 8 commits into from
Jun 28, 2021

Conversation

troy-prince-lab49
Copy link
Contributor

@troy-prince-lab49 troy-prince-lab49 commented Jun 10, 2021

This PR contains a few changes:

  1. Updated the "namespace" to be "angular-value-flash" instead of "@lab49/angular-value-flash", from Brian's recommendation that we should remove the lab49 namespace to encourage greater usage & contributions
  2. Includes the prettier configuration in the esLint config file, and the lint-stage/husky configuration for automatically running the linter with autofix when there is a commit, this includes autofixing the prettier isssues
  3. The autofixed prettier issues (such as - moving items to multiple lines or to one line, adding trailing commas)
  4. Fixed GIF permalink in README (still pointed to my repo)

commit 8994a32
Author: Troy Prince <troy.prince@lab49.com>
Date:   Thu Jun 10 14:42:08 2021 -0400

    Added full fetch depth

commit c02922e
Author: Troy Prince <troy.prince@lab49.com>
Date:   Thu Jun 10 14:35:31 2021 -0400

    added headless chrome launcher for ci/cd

commit 666aafb
Author: Troy Prince <troy.prince@lab49.com>
Date:   Thu Jun 10 14:00:59 2021 -0400

    all in one job

commit e23642c
Author: Troy Prince <troy.prince@lab49.com>
Date:   Thu Jun 10 13:28:15 2021 -0400

    merged to one job

commit 7049b93
Author: Troy Prince <troy.prince@lab49.com>
Date:   Thu Jun 10 13:26:32 2021 -0400

    added chromatic action in separate file
… classes accordingly, and config for loading a global style to storybook
@@ -0,0 +1,41 @@
.make-it-nice {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should probably go into the stories directory maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thought, I made a styles folder under stories and added it there, and removed the src folder I made, makes more sense this way because we don't really have a project root src

Copy link
Member

@brian-mcallister-lab49 brian-mcallister-lab49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just that one minor comment.

@troy-prince-lab49 troy-prince-lab49 merged commit f5a857d into main Jun 28, 2021
@troy-prince-lab49 troy-prince-lab49 deleted the prettier-and-namespace-updates branch June 28, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants