Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardening the library #191

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Deadolus
Copy link

@Deadolus Deadolus commented Nov 5, 2020

I had multiple segsev crashes in different locations all over the library.
Mostly they seem to stem from instances where the library does just assume
that some pointer is still valid, although the object was already freed.
With these changes the library now runs stable for me.
These changes are not very tidy, as I stumbled through the library
and fixed stuff one by one.
Contributing my changes back in the hope that the library will get better

  • please pick and choose and verify my changes.

Signed-off-by: Simon Egli simon.egli@arendi.ch

I had multiple segsev crashes in different locations all over the library.
Mostly they seem to stem from instances where the library does just assume
that some pointer is still valid, although the object was already freed.
With these changes the library now runs stable for me.
These changes are not very tidy, as I stumbled through the library
and fixed stuff one by one.
Contributing my changes back in the hope that the library will get better
- please pick and choose and verify my changes.

Signed-off-by: Simon Egli <simon.egli@arendi.ch>
It is ok if adapter is already scanning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant