Hardening the library #191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had multiple segsev crashes in different locations all over the library. Mostly they seem to stem from instances where the library does just assume that some pointer is still valid, although the object was already freed. With these changes the library now runs stable for me. These changes are not very tidy, as I stumbled through the library and fixed stuff one by one. Contributing my changes back in the hope that the library will get better - please pick and choose and verify my changes. Signed-off-by: Simon Egli <simon.egli@arendi.ch>
Deadolus
force-pushed
the
hardening_lib
branch
from
300dfd1
to
ffd6254
Compare
It is ok if adapter is already scanning
oliviermartin
force-pushed
the
master
branch
from
0f6ab98
to
860f7f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had multiple segsev crashes in different locations all over the library.
Mostly they seem to stem from instances where the library does just assume
that some pointer is still valid, although the object was already freed.
With these changes the library now runs stable for me.
These changes are not very tidy, as I stumbled through the library
and fixed stuff one by one.
Contributing my changes back in the hope that the library will get better
Signed-off-by: Simon Egli simon.egli@arendi.ch