minor factory fixes #258
Merged
minor factory fixes #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids surprises when _convert_to_named_list is called multiple times and simplifies the control flow a bit. Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
This code is currently unused, so the bug was not triggered. Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Codecov Report
@@ Coverage Diff @@
## master #258 +/- ##
=======================================
- Coverage 55% 55% -0.1%
=======================================
Files 105 105
Lines 6244 6243 -1
=======================================
- Hits 3438 3437 -1
Misses 2806 2806
Continue to review full report at Codecov.
|
Emantor
approved these changes
Jun 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.