This repository has been archived by the owner on Sep 22, 2023. It is now read-only.
Adaptation for API v5 revisions (Phase 1) #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
==========================================
- Coverage 42.50% 41.58% -0.93%
==========================================
Files 58 59 +1
Lines 5578 5668 +90
==========================================
- Hits 2371 2357 -14
- Misses 3207 3311 +104
Continue to review full report at Codecov.
|
* Previously, to bind the current session with API function classes,
we generated new type objects at runtime.
- This has confused IDEs and type checkers.
- Now type checkers can statically deduce the types for individual API
function classes.
- TODO: many many type errors are there still...
* Now we use contextvars (ai.backend.client.session.api_session)
to keep the reference to the current session.
- There are no public Session/AsyncSession API changes!
- Only the API function classes need to be rewritten.
- For synchronous Session, we pass the context to the separate worker
thread using copy_context() whenever calling API functions, which is
a light-weight operation.
* Remove redundant src/ai/backend/client/etcd.py which had been already
copied to src/ai/backend/client/func/etcd.py
BREAKING-CHANGE: Dropped Python 3.6 support. Now it requires Python 3.7 or higher.
* All test cases in tests/test_cli_proxy.py are marked "xfail" because there is an upstream issue rendering those tests always failing while real-world use cases have no problems. - ref) pytest-dev/pytest-asyncio#153
|
Marking this as the phase 1 of the API v5 adaptation. |
achimnol
changed the title
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.