-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: test NEO session launcher and imageList #2665
Conversation
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
9d95fd2
to
8764ac7
Compare
e2e/test-util.ts
Outdated
await page.getByRole("button",{name:"Start"}).click(); | ||
|
||
// Wait for a session to be launched | ||
await page.waitForTimeout(10000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was difficult to me that the sessions created were not immediately reflected on the screen.
So I tried a few things
- refresh ( use
navigateTo
) -> Not suitable for user scenario testing. - “Create session with session name e2e test -> Recreate session with session name e2e test. Check the failure statement that a session has already been created”
I tried to run the test with the above scenario. But It isn't a good fit for user scenario testing either. - Increasing the
waitForTimeout
time
I thought option 3 works best and I applied that method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of page.waitForTimeout(10000), we can use locator's wait. Please check my recent commit.
await expect(session).toBeVisible({timeout: 10000});
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I check it. Create session returns a passed. But session test fails. Because the timeout (await page.waitForTimeout(5000);
)was removed and the session termination was not immediately reflected on the screen.
So I think that Delete session test needs Timeout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comments and commits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a commit please check it.
Now, LGTM! Thank you for your contribution.
Merge activity
|
630ca50
to
11ca13f
Compare
This PR resolves #2657 issue
TL;DR
e2e test for NEO session creation and
imageList
What changed?
Test: