Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing load the maxGaudi2DevicesPerContainer #2681

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Sep 3, 2024

TL;DR

This PR resolves the bug where maxGaudi2DevicesPerContainer was not being applied.

  • Load the client configuration to include the maxGaudi2DevicesPerContainer value.

Copy link

graphite-app bot commented Sep 3, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

yomybaby commented Sep 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @yomybaby and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the size:S 10~30 LoC label Sep 3, 2024
@yomybaby yomybaby marked this pull request as ready for review September 3, 2024 07:32
Copy link
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rapsealk rapsealk changed the title fix: missing load themaxGaudi2DevicesPerContainer fix: missing load the maxGaudi2DevicesPerContainer Sep 3, 2024
Copy link

graphite-app bot commented Sep 3, 2024

Merge activity

### TL;DR

This PR resolves the bug where `maxGaudi2DevicesPerContainer` was not being applied.
- Load the client configuration to include the `maxGaudi2DevicesPerContainer` value.
@yomybaby yomybaby force-pushed the fix/maxGaudi2DevicesPerContainer branch from 68baa6a to 7a8202d Compare September 3, 2024 10:51
Base automatically changed from feature/support-gaudi-2 to main September 3, 2024 10:53
@graphite-app graphite-app bot merged commit 7a8202d into main Sep 3, 2024
4 checks passed
@graphite-app graphite-app bot deleted the fix/maxGaudi2DevicesPerContainer branch September 3, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S 10~30 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants