feat: fetch container registries with new nodes query #2746

agatha197 · 2024-10-10T10:51:37Z

related PR: feat: Migrate container registry config storage from Etcd to PostgreSQL backend.ai#1917, fix: Make image table's project, registry_id column nullable backend.ai#2888

TR;DR
New GraphQL queries and mutations have been added related to the Registry since 24.09. Internally, the management from etcd has been changed to DB table. Therefore, version management is as follows:

24.09.0 and above: Use ContainerRegistryList.tsx, ContainerRegistryEditorModal.tsx
23.09.2 and above but below 24.09.0: Use ContainerRegistryListBefore2409.tsx, ContainerRegistryEditorModalBefore2409.tsx
Below 23.09.2: Use backend-ai-registry-list.ts

What's changed

ContainerRegistryList.tsx and ContainerRegistryEditorModal.tsx have been renamed to ContainerRegistryListBefore2409.tsx, ContainerRegistryEditorModalBefore2409.tsx.
From 24.09.0, ContainerRegistryList.tsx and ContainerRegistryEditorModal.tsx use container_registry_nodes related query and mutation.
Pagination and sorting (only for registry name) are supported.
Updated schema

How to test

Change

backend.ai-webui/react/src/pages/EnvironmentPage.tsx

Lines 65 to 73 in 7163812

    
           isSupportContainerRegistryGraphQL ? ( 
        
             isSupportContainerRegistryNodes ? ( 
        
               // manager ≤ v24.09.0 
        
               <ContainerRegistryList /> 
        
             ) : ( 
        
               // v23.09.2 ≤ manager < v24.09.0 
        
               <ContainerRegistryListBefore2409 /> 
        
             ) 
        
           ) : (

to like this.

isSupportContainerRegistryGraphQL ? (
    <ContainerRegistryList />
) : (

Change this line

backend.ai-webui/react/src/components/ContainerRegistryList.tsx

Line 87 in 7163812

) @since(version: "24.09.0") {

to like this. (since 24.09.0 is not released yet).

          ) @since(version: "24.09.0b1") {

Go to Environments - Registries page.

Checklist for reviewers

CRUD registries.
The project is set to 'library' when the type is 'docker' and the input field is disabled.
Registry name filtering and sorting work well.
Pagination works well.
- For testing this, you can add '1' option to this line.
  
  backend.ai-webui/react/src/components/ContainerRegistryList.tsx
  
  Line 347 in a7ab1ed
  
  pageSizeOptions: ['10', '20', '50'],

Checklist: (if applicable)

Mention to the original issue
Documentation
Minium required manager version
Specific setting for review (eg., KB link, endpoint or how to setup)
Minimum requirements to check during review
Test case(s) to demonstrate the difference of before/after

graphite-app · 2024-10-10T10:51:42Z

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

agatha197 · 2024-10-10T10:51:51Z

feat: add TableColumnSettingModal to ContainerRegistryList #2752
feat: fetch container registries with new nodes query #2746 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @agatha197 and the rest of your teammates on Graphite

github-actions · 2024-10-11T06:54:08Z

Coverage report for `./react`

St.^❔	Category	Percentage	Covered / Total
🔴	Statements	5.15%	348/6752
🔴	Branches	4.7%	218/4643
🔴	Functions	3.02%	67/2222
🔴	Lines	5.05%	333/6597

Test suite run success

93 tests passing in 12 suites.

Report generated by 🧪jest coverage report action from ccb9a9b

lizable

LGTM.

graphite-app · 2024-10-21T04:40:02Z

Merge activity

Oct 21, 12:40 AM EDT: A user added this pull request to the Graphite merge queue.
Oct 21, 12:41 AM EDT: A user merged this pull request with the Graphite merge queue.

@SInCE

- related PR: lablup/backend.ai#1917, lablup/backend.ai#2888 **TR;DR** New GraphQL queries and mutations have been added related to the Registry since 24.09. Internally, the management from etcd has been changed to DB table. Therefore, version management is as follows: - 24.09.0 and above: Use `ContainerRegistryList.tsx`, `ContainerRegistryEditorModal.tsx` - 23.09.2 and above but below 24.09.0: Use `ContainerRegistryListBefore2409.tsx`, `ContainerRegistryEditorModalBefore2409.tsx` - Below 23.09.2: Use `backend-ai-registry-list.ts` **What's changed** - `ContainerRegistryList.tsx` and `ContainerRegistryEditorModal.tsx` have been renamed to `ContainerRegistryListBefore2409.tsx`, `ContainerRegistryEditorModalBefore2409.tsx`. - From 24.09.0, `ContainerRegistryList.tsx` and `ContainerRegistryEditorModal.tsx` use `container_registry_nodes` related query and mutation. - Pagination and sorting (only for registry name) are supported. - Updated schema **How to test** 1. Change https://github.com/lablup/backend.ai-webui/blob/7163812c4b3a70679b0efb347e11b52c3f9948cb/react/src/pages/EnvironmentPage.tsx#L65-L73 to like this. ```ts isSupportContainerRegistryGraphQL ? ( <ContainerRegistryList /> ) : ( ```` 2. Change this line https://github.com/lablup/backend.ai-webui/blob/7163812c4b3a70679b0efb347e11b52c3f9948cb/react/src/components/ContainerRegistryList.tsx#L87 to like this. (since 24.09.0 is not released yet). ```ts ) @SInCE(version: "24.09.0b1") { ``` 3. Go to Environments - Registries page. **Checklist for reviewers** - [ ] CRUD registries. - [ ] The project is set to 'library' when the type is 'docker' and the input field is disabled. - [ ] Registry name filtering and sorting work well. - [ ] Pagination works well. - For testing this, you can add '1' option to this line. https://github.com/lablup/backend.ai-webui/blob/a7ab1ed6fe540070010f87a437f52c1c42b30abc/react/src/components/ContainerRegistryList.tsx#L347 **Checklist:** (if applicable) - [x] Mention to the original issue - [ ] Documentation - [x] Minium required manager version - [x] Specific setting for review (eg., KB link, endpoint or how to setup) - [x] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after

github-actions bot assigned agatha197 Oct 10, 2024

github-actions bot added area:lib Library and SDK related issue. area:ux UI / UX issue. area:i18n Localization size:XL 500~ LoC labels Oct 10, 2024

agatha197 force-pushed the feature/fetch-container-registries-with-nodes branch 4 times, most recently from baabae1 to 924a6c1 Compare October 11, 2024 06:52

agatha197 force-pushed the feature/fetch-container-registries-with-nodes branch 3 times, most recently from 326e2fd to a7ab1ed Compare October 11, 2024 07:21

agatha197 marked this pull request as ready for review October 11, 2024 07:23

agatha197 requested review from ironAiken2, lizable and yomybaby October 11, 2024 07:24

agatha197 added this to the 24.09 milestone Oct 11, 2024

agatha197 force-pushed the feature/fetch-container-registries-with-nodes branch 2 times, most recently from 5d2b8ab to 983c8ff Compare October 15, 2024 04:31

agatha197 mentioned this pull request Oct 15, 2024

feat: add TableColumnSettingModal to ContainerRegistryList #2752

Merged

2 tasks

agatha197 force-pushed the feature/fetch-container-registries-with-nodes branch 3 times, most recently from fa69e9c to 18d5597 Compare October 15, 2024 06:24

agatha197 added the urgency:blocker IT SHOULD BE RESOLVED BEFORE DISTRIBUTING label Oct 15, 2024

agatha197 force-pushed the feature/fetch-container-registries-with-nodes branch from 18d5597 to 84e86de Compare October 17, 2024 08:58

lizable approved these changes Oct 21, 2024

View reviewed changes

lizable force-pushed the feature/fetch-container-registries-with-nodes branch from 84e86de to ccb9a9b Compare October 21, 2024 04:40

graphite-app bot merged commit ccb9a9b into main Oct 21, 2024
6 checks passed

graphite-app bot deleted the feature/fetch-container-registries-with-nodes branch October 21, 2024 04:41

github-pages bot temporarily deployed to github-pages October 21, 2024 04:42 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: fetch container registries with new nodes query #2746

feat: fetch container registries with new nodes query #2746

agatha197 commented Oct 10, 2024 •

edited

Loading

graphite-app bot commented Oct 10, 2024

agatha197 commented Oct 10, 2024 •

edited

Loading

github-actions bot commented Oct 11, 2024 •

edited

Loading

lizable left a comment

graphite-app bot commented Oct 21, 2024 •

edited by lizable

Loading

	isSupportContainerRegistryGraphQL ? (
	isSupportContainerRegistryNodes ? (
	// manager ≤ v24.09.0
	<ContainerRegistryList />
	) : (
	// v23.09.2 ≤ manager < v24.09.0
	<ContainerRegistryListBefore2409 />
	)
	) : (

feat: fetch container registries with new nodes query #2746

feat: fetch container registries with new nodes query #2746

Conversation

agatha197 commented Oct 10, 2024 • edited Loading

graphite-app bot commented Oct 10, 2024

Your org requires the Graphite merge queue for merging into main

agatha197 commented Oct 10, 2024 • edited Loading

github-actions bot commented Oct 11, 2024 • edited Loading

Coverage report for ./react

Test suite run success

lizable left a comment

Choose a reason for hiding this comment

graphite-app bot commented Oct 21, 2024 • edited by lizable Loading

Merge activity

agatha197 commented Oct 10, 2024 •

edited

Loading

agatha197 commented Oct 10, 2024 •

edited

Loading

github-actions bot commented Oct 11, 2024 •

edited

Loading

Coverage report for `./react`

graphite-app bot commented Oct 21, 2024 •

edited by lizable

Loading