Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow duplicate hostname for container registries #2756

Closed

Conversation

rapsealk
Copy link
Member

Follow-up of lablup/backend.ai#1917.

This pull request updates to embrace duplicated hostname when creating a new container registry, as the ContainerRegistry.registry_name field is not unique.

image

Checklist: (if applicable)

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@rapsealk rapsealk added this to the 24.09 milestone Oct 17, 2024
@rapsealk rapsealk self-assigned this Oct 17, 2024
Copy link

graphite-app bot commented Oct 17, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added area:ux UI / UX issue. area:i18n Localization size:M 30~100 LoC labels Oct 17, 2024
Copy link

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
5.33% (+0% 🔼)
348/6529
🔴 Branches
4.83% (+0.01% 🔼)
218/4516
🔴 Functions
3.1% (+0% 🔼)
67/2162
🔴 Lines
5.22% (+0% 🔼)
333/6377

Test suite run success

93 tests passing in 12 suites.

Report generated by 🧪jest coverage report action from ab2d0cf

@agatha197
Copy link
Contributor

@agatha197 agatha197 closed this Oct 17, 2024
@rapsealk rapsealk deleted the feature/allow-duplicated-container-registry-hostname branch October 17, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:ux UI / UX issue. size:M 30~100 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants