fix: check-docker.py script not working
#2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on |
agatha197
added
type:maintenance
|
As noted at psf/requests#6707 (comment) requests won't rollback the regression, so I think it is up to us to refactor the root cause from our side, rather than just keep pinning request version forever. |
kyujin-cho
changed the title
check-docker.py script not working
Merge activity
|
This PR resolves `install-dev.sh` script failing due to recent changes in `requests` library by lifting up dependencies to `requests` and instead benefiting from `aiohttp`'s native Unix Domain Socket connector feature. **Checklist:** (if applicable) - [ ] Milestone metadata specifying the target backport version
kyujin-cho
force-pushed
the
chore_Update_pip_dependencies_for_requests
branch
from
756fc9a
to
a986441
Compare
kyujin-cho
pushed a commit
that referenced
this pull request
Jul 9, 2024
Backported-from: main (24.09) Backported-to: 24.03 Backport-of: 2174
kyujin-cho
pushed a commit
that referenced
this pull request
Jul 9, 2024
Backported-from: main (24.09) Backported-to: 23.09 Backport-of: 2174
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves
install-dev.shscript failing due to recent changes inrequestslibrary by lifting up dependencies torequestsand instead benefiting fromaiohttp's native Unix Domain Socket connector feature.Checklist: (if applicable)