chore: Update git pre-push hook to use correct base branch name #2626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achimnol
added
type:bug
achimnol
added
the
skip:changelog
achimnol
deleted the
topic/use-gh-cli-to-get-the-correct-base-branch-for-pre-push-hook
branch
lablup-octodog
pushed a commit
that referenced
this pull request
Aug 3, 2024
Backported-from: main (24.09) Backported-to: 23.03 Backport-of: 2626
lablup-octodog
pushed a commit
that referenced
this pull request
Aug 3, 2024
Backported-from: main (24.09) Backported-to: 24.03 Backport-of: 2626
This was referenced Aug 3, 2024
lablup-octodog
pushed a commit
that referenced
this pull request
Aug 3, 2024
Backported-from: main (24.09) Backported-to: 23.09 Backport-of: 2626
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 3, 2024
… (#2629) Co-authored-by: Joongi Kim <joongi@lablup.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 3, 2024
… (#2628) Co-authored-by: Joongi Kim <joongi@lablup.com>
achimnol
added a commit
that referenced
this pull request
Aug 3, 2024
… (#2627) Co-authored-by: Joongi Kim <joongi@lablup.com>
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #2625, I found that the current pre-push hook does not detect the correct base branch name when it executes
pants lint check --changed-since=.... We can fix this by getting the base branch reference from GitHub, usinggh(GitHub CLI) if installed.To maintain independency of the toolchain from GitHub, let the pre-push script gracefully fallback to the full lint & check when
ghis not available.Checklist: (if applicable)