Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Verify that the current model schema and the migration file match #2716

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Yaminyam
Copy link
Member

@Yaminyam Yaminyam commented Aug 14, 2024

Validate that the alembic revision file matches the current model schema by checking that no changes were made when it was created.
The require:db-migration changes the trigger condition of check-alembic-migration because it is a label that we attach if there is a change in the actual revision file.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

@Yaminyam Yaminyam added this to the 24.09 milestone Aug 14, 2024
@Yaminyam Yaminyam requested a review from achimnol August 14, 2024 11:25
@github-actions github-actions bot added the size:M 30~100 LoC label Aug 14, 2024
@Yaminyam Yaminyam added the skip:changelog Make the action workflow to skip towncrier check label Aug 14, 2024
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Yaminyam Yaminyam requested a review from achimnol August 16, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M 30~100 LoC skip:changelog Make the action workflow to skip towncrier check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants