fix: Assign the initial value of occupying_slots to the value of requested_slots
#2730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to the value of `requested_slots`
.fix.md -> 2730.fix.md
lizable
added
the
urgency:blocker
Graphite App
fregataa
requested changes
Aug 20, 2024
| @@ -1273,6 +1273,7 @@ async def _enqueue() -> None: | |||
|
|
|||
| session_data["environ"] = environ | |||
| session_data["requested_slots"] = session_requested_slots | |||
| session_data["occupying_slots"] = session_requested_slots | |||
There was a problem hiding this comment.
This will double the value of sessions.occupying_slots because the value of actual allocated resource is added to this in finalize_running().
We should update the finalize_running() or change this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1115, we did something to initialize occupied_slots to the value of requested_slots when creating the kernel.
The session's data value also ensures that occupying_slots is not empty, so that it has a value even when the session is in PREPARE or PENDING state.
Checklist: (if applicable)