feat: Add log-level to background task message #2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
comp:common
This was referenced Aug 20, 2024
fregataa
force-pushed
the
topic/08-19-feat_apply_semaphore_and_file-lock_on_folder_deletion
branch
from
e638f83
to
ee7792f
Compare
fregataa
force-pushed
the
topic/08-20-feat_add_log_level_to_background_task_message
branch
from
6aea086
to
c0d9a00
Compare
2 tasks
fregataa
force-pushed
the
topic/08-19-feat_apply_semaphore_and_file-lock_on_folder_deletion
branch
from
ee7792f
to
be917b0
Compare
fregataa
force-pushed
the
topic/08-20-feat_add_log_level_to_background_task_message
branch
from
c0d9a00
to
eb2eba0
Compare
2 tasks
fregataa
force-pushed
the
topic/08-20-feat_add_log_level_to_background_task_message
branch
from
eb2eba0
to
ea42f4a
Compare
fregataa
changed the base branch from
topic/08-19-feat_apply_semaphore_and_file-lock_on_folder_deletion
to
main
fregataa
added
the
skip:changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's add
log_levelfield to background task event.Current implementation of bgtask updates its progress with number type current & total progress and string type message.
Such implementation cannot inform clients of a granular failure of the total bgtask through progress reporter.
e.g. A task deleting multiple vfolders has failed to delete a few of them.
Adding
log_levelfield could resolve this issue.Checklist: (if applicable)