Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Invalid image format log spam in Agent #2894

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

jopemachine
Copy link
Member

Resolves #2893.

This PR prevents the console from being flooded with duplicate error Image name ... does not conform to Backend.AI's image naming rule log messages.

Error log messages will now be printed only once, not being outputted on each image rescan cycle.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue

@jopemachine jopemachine added type:bug Reports about that are not working comp:agent Related to Agent component labels Oct 8, 2024
@jopemachine jopemachine self-assigned this Oct 8, 2024
@jopemachine jopemachine changed the title fix: Invalid image format log spam in agent fix: Invalid image format log spam in Agent Oct 8, 2024
@github-actions github-actions bot added the size:S 10~30 LoC label Oct 8, 2024
@jopemachine jopemachine marked this pull request as ready for review October 8, 2024 01:45
@jopemachine jopemachine added this to the 24.03 milestone Oct 8, 2024
@jopemachine jopemachine requested a review from achimnol October 8, 2024 01:52
@achimnol achimnol closed this Oct 8, 2024
@achimnol achimnol reopened this Oct 8, 2024
@achimnol achimnol enabled auto-merge October 8, 2024 03:26
@achimnol achimnol added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 76dd014 Oct 8, 2024
35 of 37 checks passed
@achimnol achimnol deleted the fix/invalid-image-warning-spam-on-agent branch October 8, 2024 03:31
lablup-octodog pushed a commit that referenced this pull request Oct 8, 2024
Backported-from: main (24.09)
Backported-to: 24.03
Backport-of: 2894
github-merge-queue bot pushed a commit that referenced this pull request Oct 8, 2024
Co-authored-by: Gyubong Lee <jopemachine@naver.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:agent Related to Agent component size:S 10~30 LoC type:bug Reports about that are not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeated log spamming of "ImageName invalid" error message in the Agent
2 participants