Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wrong creation of raw_configs in _create_kernels_in_one_agent #2896

Conversation

jopemachine
Copy link
Member

Follow-up of #2707.

Fixed wrong logic generating raw_configs.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

@jopemachine jopemachine added the type:bug Reports about that are not working label Oct 8, 2024
@jopemachine jopemachine added this to the 24.09 milestone Oct 8, 2024
@jopemachine jopemachine requested a review from kyujin-cho October 8, 2024 06:04
@jopemachine jopemachine self-assigned this Oct 8, 2024
@github-actions github-actions bot added comp:manager Related to Manager component size:M 30~100 LoC labels Oct 8, 2024
@jopemachine jopemachine marked this pull request as ready for review October 8, 2024 06:06
@kyujin-cho kyujin-cho enabled auto-merge October 8, 2024 06:09
@kyujin-cho kyujin-cho added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 9c3d23f Oct 8, 2024
18 of 20 checks passed
@kyujin-cho kyujin-cho deleted the fix/wrong-creation-of-raw-configs-in-create-kernels-in-one-agents branch October 8, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component size:M 30~100 LoC type:bug Reports about that are not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants