Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BA-463): Implement APIs for associating, disassociating container_registries with groups #3067

Open
wants to merge 21 commits into
base: topic/11-11-feat_implement_associationcontainerregistriesgroupsrow_
Choose a base branch
from

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Nov 11, 2024

Resolves #3396 (BA-463).

Implement APIs for associating, disassociating container_registries with groups.

Implementation Check list

  • REST API
  • Graphql API
  • Client SDK

Client code example

import asyncio
from ai.backend.client.session import AsyncSession

async def main():
    async with AsyncSession() as session:
        # result: {'ok': True, 'msg': 'success'}
        result = await session.ContainerRegistry.associate_group("<registry_id>", "<group_id>")

if __name__ == "__main__":
    asyncio.run(main())

GQL example

mutation {
  associate_container_registry_with_group (group_id: "<GROUP_ID>", registry_id: "<REGISTRY_ID>") {
    ok
  }
}

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • API server-client counterparts (e.g., manager API -> client SDK)

📚 Documentation preview 📚: https://sorna--3067.org.readthedocs.build/en/3067/


📚 Documentation preview 📚: https://sorna-ko--3067.org.readthedocs.build/ko/3067/

@github-actions github-actions bot added area:docs Documentations comp:manager Related to Manager component size:L 100~500 LoC labels Nov 11, 2024
@jopemachine jopemachine added this to the 24.12 milestone Nov 11, 2024
@jopemachine jopemachine added the type:feature Add new features label Nov 11, 2024
@jopemachine jopemachine force-pushed the topic/11-11-feat_implement_associatecontainerregistrywithgroup_disassociatecontainerregistrywithgroup_ branch 2 times, most recently from 611d621 to b2e3d16 Compare November 11, 2024 06:00
@jopemachine jopemachine changed the title feat: Implement AssociateContainerRegistryWithGroup, DisassociateContainerRegistryWithGroup feat: Implement APIs for associating, disassociating container_registries with groups Nov 11, 2024
@jopemachine jopemachine marked this pull request as ready for review November 12, 2024 05:19
@jopemachine jopemachine requested a review from fregataa November 12, 2024 05:23
@jopemachine jopemachine added action:on hold Hold it. Wait for the restart. and removed action:on hold Hold it. Wait for the restart. labels Nov 12, 2024
@jopemachine jopemachine force-pushed the topic/11-11-feat_implement_associationcontainerregistriesgroupsrow_ branch from b255920 to c1c349c Compare November 13, 2024 06:29
@jopemachine jopemachine force-pushed the topic/11-11-feat_implement_associatecontainerregistrywithgroup_disassociatecontainerregistrywithgroup_ branch 2 times, most recently from e867c2f to 3d09864 Compare November 13, 2024 08:36
@jopemachine jopemachine force-pushed the topic/11-11-feat_implement_associationcontainerregistriesgroupsrow_ branch from b2abda9 to 6004978 Compare November 14, 2024 06:00
@jopemachine jopemachine force-pushed the topic/11-11-feat_implement_associatecontainerregistrywithgroup_disassociatecontainerregistrywithgroup_ branch 2 times, most recently from 5c60323 to 39dda7f Compare November 18, 2024 01:16
@jopemachine jopemachine force-pushed the topic/11-11-feat_implement_associationcontainerregistriesgroupsrow_ branch from d4ce974 to bebc68e Compare November 18, 2024 01:28
@jopemachine jopemachine force-pushed the topic/11-11-feat_implement_associatecontainerregistrywithgroup_disassociatecontainerregistrywithgroup_ branch 2 times, most recently from 84fd5ca to 6065f3d Compare November 18, 2024 01:33
@jopemachine jopemachine force-pushed the topic/11-11-feat_implement_associationcontainerregistriesgroupsrow_ branch from 5e6f6ed to 5cad46c Compare November 20, 2024 06:44
src/ai/backend/manager/api/container_registry.py Outdated Show resolved Hide resolved
src/ai/backend/manager/api/container_registry.py Outdated Show resolved Hide resolved
src/ai/backend/manager/api/container_registry.py Outdated Show resolved Hide resolved
src/ai/backend/manager/api/container_registry.py Outdated Show resolved Hide resolved
@jopemachine jopemachine modified the milestones: 24.12, 25Q1 Jan 6, 2025
@jopemachine jopemachine force-pushed the topic/11-11-feat_implement_associationcontainerregistriesgroupsrow_ branch from 1e9f8f6 to 0c496b5 Compare January 6, 2025 07:00
@jopemachine jopemachine force-pushed the topic/11-11-feat_implement_associatecontainerregistrywithgroup_disassociatecontainerregistrywithgroup_ branch from 17443b3 to b1f2bef Compare January 6, 2025 07:01
@jopemachine jopemachine changed the title feat: Implement APIs for associating, disassociating container_registries with groups feat(BA-463): Implement APIs for associating, disassociating container_registries with groups Jan 8, 2025
@fregataa fregataa self-requested a review January 8, 2025 08:02
@jopemachine jopemachine force-pushed the topic/11-11-feat_implement_associatecontainerregistrywithgroup_disassociatecontainerregistrywithgroup_ branch from 23a194c to 978b571 Compare January 10, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Documentations comp:client Related to Client component comp:manager Related to Manager component size:XL 500~ LoC type:feature Add new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants