Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Split config/halfstack/global contexts from root context #3154

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

achimnol
Copy link
Member

@achimnol achimnol commented Nov 27, 2024

This PR splits RootContext into three categories of contextual objects:

  • Configurations (those from etcd and local TOML files, runtime identifier like pidx)
  • Halfstack connection pools (postgres and redis)
  • Global stateful objects (event bus, background task manager, storage proxy connector, etc.)

Relationship:

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue

Copy link
Member Author

achimnol commented Nov 27, 2024

@achimnol achimnol force-pushed the refactor/rootctx-hierarchical-init branch from 8ce4dc0 to 46c011a Compare November 27, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor RootContext to explicitly distinguish context info groups
1 participant