Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Replace vfolder's status_history's type dict with list #3205

Open
wants to merge 5 commits into
base: topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_
Choose a base branch
from
Open

feat: Replace vfolder's status_history's type dict with list #3205

wants to merge 5 commits into from
+90 −13

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Dec 5, 2024 •
edited by jira bot
Loading

Part of #767, #3214 (BA-14).

The current implementation saves only the most recent timestamp whenever status information in status_history is updated, and all previous information is deleted.

This PR prevents the loss of timestamp information by changing the data structure of vfolders' status_history to List.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue

@jopemachine Graphite App
Copy link
Member Author

jopemachine commented Dec 5, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jopemachine jopemachine mentioned this pull request Dec 5, 2024
Open
2 tasks
@github-actions github-actions bot added comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated labels Dec 5, 2024
@jopemachine jopemachine mentioned this pull request Dec 5, 2024
Open
2 tasks
@github-actions github-actions bot added the size:M 30~100 LoC label Dec 5, 2024
@jopemachine jopemachine mentioned this pull request Dec 5, 2024
Closed
2 tasks
@jopemachine jopemachine added the type:refactor Refactor codes or add tests. label Dec 5, 2024
@jopemachine jopemachine added this to the 24.12 milestone Dec 5, 2024
@jopemachine jopemachine added the type:feature Add new features label Dec 6, 2024
@jopemachine jopemachine marked this pull request as ready for review December 6, 2024 03:36
@jopemachine jopemachine force-pushed the topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_ branch from ecef6b9 to a4905e7 Compare December 6, 2024 08:20
@jopemachine jopemachine force-pushed the topic/12-05-feat_replace_vfolder_s_status_history_s_type_dict_with_list_ branch from 771f2e4 to 314a6e0 Compare December 6, 2024 08:20
@jopemachine jopemachine force-pushed the topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_ branch from a4905e7 to f28038b Compare December 8, 2024 07:09
@jopemachine jopemachine force-pushed the topic/12-05-feat_replace_vfolder_s_status_history_s_type_dict_with_list_ branch from 02f7617 to b6e059c Compare December 8, 2024 07:09
@jopemachine jopemachine force-pushed the topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_ branch from f28038b to ee4f67c Compare December 9, 2024 05:23
@jopemachine jopemachine force-pushed the topic/12-05-feat_replace_vfolder_s_status_history_s_type_dict_with_list_ branch from b6e059c to 8b3fe90 Compare December 9, 2024 05:23
@jopemachine jopemachine force-pushed the topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_ branch from ee4f67c to 44b11bf Compare December 9, 2024 05:25
@jopemachine jopemachine force-pushed the topic/12-05-feat_replace_vfolder_s_status_history_s_type_dict_with_list_ branch from 8b3fe90 to 08ea1e7 Compare December 9, 2024 05:25
@jopemachine jopemachine force-pushed the topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_ branch from 44b11bf to d4d43ac Compare December 9, 2024 05:27
@jopemachine jopemachine force-pushed the topic/12-05-feat_replace_vfolder_s_status_history_s_type_dict_with_list_ branch from fb372c7 to 2ad9ea2 Compare December 9, 2024 05:27
@jopemachine jopemachine force-pushed the topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_ branch from d4d43ac to b544fc1 Compare December 10, 2024 00:39
@jopemachine jopemachine force-pushed the topic/12-05-feat_replace_vfolder_s_status_history_s_type_dict_with_list_ branch from 2ad9ea2 to 4c0d0c7 Compare December 10, 2024 00:39
@jopemachine jopemachine force-pushed the topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_ branch from b544fc1 to 6327969 Compare December 10, 2024 06:42
@jopemachine jopemachine force-pushed the topic/12-05-feat_replace_vfolder_s_status_history_s_type_dict_with_list_ branch from 4c0d0c7 to d6b288e Compare December 10, 2024 06:42
@jopemachine jopemachine force-pushed the topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_ branch from 6327969 to dfe91a5 Compare December 13, 2024 00:58
@jopemachine jopemachine force-pushed the topic/12-05-feat_replace_vfolder_s_status_history_s_type_dict_with_list_ branch from 6120bee to c153753 Compare December 13, 2024 00:58
HyeockJinKim
HyeockJinKim approved these changes Dec 17, 2024
View reviewed changes
Copy link

@HyeockJinKim HyeockJinKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, I'd like to see a way to create a new column when changing the data format and store it in both columns for compatibility.

@jopemachine jopemachine force-pushed the topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_ branch from dfe91a5 to 9c01133 Compare December 23, 2024 01:01
@jopemachine jopemachine force-pushed the topic/12-05-feat_replace_vfolder_s_status_history_s_type_dict_with_list_ branch from c153753 to 06c583a Compare December 23, 2024 01:01
@github-actions github-actions bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels Dec 23, 2024
@jopemachine jopemachine force-pushed the topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_ branch from 9c01133 to a77b099 Compare December 23, 2024 02:18
@jopemachine jopemachine force-pushed the topic/12-05-feat_replace_vfolder_s_status_history_s_type_dict_with_list_ branch from 06c583a to bc02b7f Compare December 23, 2024 02:18
@jopemachine jopemachine force-pushed the topic/12-05-feat_add_dummy_kernels_table_for_testing_sql_json_merge_ branch from a77b099 to c062933 Compare December 23, 2024 02:22
@jopemachine jopemachine force-pushed the topic/12-05-feat_replace_vfolder_s_status_history_s_type_dict_with_list_ branch from bc02b7f to 0c53d12 Compare December 23, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyeockJinKim HyeockJinKim HyeockJinKim approved these changes

Assignees

@jopemachine jopemachine

Labels
comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated size:L 100~500 LoC type:feature Add new features type:refactor Refactor codes or add tests.
Projects
None yet
Milestone
24.12
Development

Successfully merging this pull request may close these issues.
2 participants
@jopemachine @HyeockJinKim