-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: restart model service process #3282
Open
kyujin-cho
wants to merge
12
commits into
main
Choose a base branch
from
feature/restart-model-service-process
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:docs
Documentations
comp:manager
Related to Manager component
comp:agent
Related to Agent component
size:L
100~500 LoC
labels
Dec 20, 2024
kyujin-cho
changed the title
feature: restart model service process
feat: restart model service process
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:docs
Documentations
comp:agent
Related to Agent component
comp:manager
Related to Manager component
size:XL
500~ LoC
type:feature
Add new features
urgency:blocker
IT SHOULD BE RESOLVED BEFORE NEXT RELEASE!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances model service reloading experience by enabling user to restart model process only, not the whole container. Since this only stops and reloads the process itself, any changes applied to container spec (e.g. image, resource request, env var, ...) will not be reflected.
What's changed
Backend.AI Agent
restart_model_service()
RPC functionAbstractAgent.load_model_definition()
) fromAbstractAgent
onto a new classModelServiceManager
AbstractKernel
to remember informations about its model service information (model_service_info
), which was considered as volatile beforeAbstractAgent.restart_model_service()
)model_service_info
andModelServiceManager
to shutdown existing model service process and replicate the recreation process, which was only done at kernel start process until nowBackend.AI Kernel
shutdown_model_service()
functionBackend.AI Manager
restart_model_service
REST API andrestart_model_service
registry functionChecklist: (if applicable)
📚 Documentation preview 📚: https://sorna--3282.org.readthedocs.build/en/3282/
📚 Documentation preview 📚: https://sorna-ko--3282.org.readthedocs.build/ko/3282/