feat: VFolder trash bin #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregataa
added
type:feature
fregataa
force-pushed
the
feature/vfolder-trash-bin
branch
from
6131aa3 to
dc8d30c
Compare
fregataa
force-pushed
the
feature/vfolder-trash-bin
branch
from
dc8d30c to
4fd6dd7
Compare
kyujin-cho
requested changes
Nov 4, 2022
|
TODO
|
…feature/vfolder-trash-bin
kyujin-cho
requested changes
Oct 4, 2023
src/ai/backend/manager/defs.py
Outdated
| @@ -72,6 +72,7 @@ class LockID(enum.IntEnum): | |||
| LOCKID_SCALE_TIMER = 193 | |||
| LOCKID_LOG_CLEANUP_TIMER = 195 | |||
| LOCKID_IDLE_CHECK_TIMER = 196 | |||
| LOCKID_STORAGE_TIMER = 197 | |||
There was a problem hiding this comment.
Looks like this LockID is not used anymore.
| DELETE_ONGOING = "delete-ongoing" # vfolder is being deleted | ||
| DELETE_COMPLETE = "deleted-complete" # vfolder is deleted | ||
| PURGE_ONGOING = "purge-ongoing" # vfolder is being removed permanently | ||
| # PURGE_COMPLETE = "purged-complete" # vfolder is removed permanently |
There was a problem hiding this comment.
Please remove commented out, unused snippet from the file.
| VFolderOperationStatus.MOUNTED, | ||
| } | ||
| case VFolderAccessStatus.UPDATABLE: | ||
| # if UPDATABLE access status is requested, READY and MOUNTED operation statuses are accepted. | ||
| # if UPDATABLE access status is requested, only READY operation status is accepted. |
There was a problem hiding this comment.
Looks like this comment contradicts with actual implementation.
kyujin-cho
changed the title
5 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: #767
1. impl trash bin in vfs storagedeleteAPI only updates the status column of vfolder table at manager, andpurgeAPI deletes the real data.DELETE_ONGOINGorPURGE_ONGOINGetc.3. impl storage trash bin checker in manager dispatcher.storage_check_interval_daysin manager's shared_config set the interval of trash bin checker.Q: How should we determine duplicate new created vfolder name if we do not delete actual data in DB?
purge_vfolderremove the db row and remove the actual vfolder.The name of
DELETEDvfolders can not be used for new created vfolders but the name ofPURGEDvfolders are available.-> Decided to remove
PURGEDvfolder row.