Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoRA #266

Merged
merged 11 commits into from
Jul 31, 2024
Merged

LoRA #266

merged 11 commits into from
Jul 31, 2024

Conversation

lakshith-403
Copy link
Member

No description provided.



# from transformers
class NewGELUActivation(nn.Module):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does nn.GeLU produce different results?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt know there was one. will check



# from transformers
class Conv1D(nn.Module):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use nn.Linear

self.c_att = Conv1D(config['n_embd'] * 3, config['n_embd'])
self.c_proj = Conv1D(config['n_embd'], config['n_embd'])

self.resid_dropout = nn.Dropout(config['resid_pdrop'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets remove dropout for simplicity

@vpj vpj mentioned this pull request Jul 31, 2024
@vpj vpj merged commit 957ade6 into labmlai:master Jul 31, 2024
@lakshith-403 lakshith-403 deleted the LoRA branch August 6, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants