feat(server): hot load environments for runtime instead of restarting…

… runtime (#1077)

e2e/f1-payload.json

@@ -1,7 +1,6 @@
 {
   "name": "f1",
   "description": "laf e2e function(hello-laf)",
-  "websocket": false,
   "methods": [
     "GET",
     "POST"

e2e/f2-origin-payload.json

@@ -1,7 +1,6 @@
 {
   "name": "f2",
   "description": "laf e2e function(db example)",
-  "websocket": false,
   "methods": [
     "GET",
     "POST"

runtimes/nodejs/src/constants.ts

@@ -4,7 +4,7 @@
 export const CLOUD_FUNCTION_COLLECTION = '__functions__'
 export const POLICY_COLLECTION = '__policies__'
 export const FUNCTION_LOG_COLLECTION = '__function_logs__'
-export const CONFIG_COLLECTION = '__config__'
+export const CONFIG_COLLECTION = '__conf__'
 
 export const WEBSOCKET_FUNCTION_NAME = '__websocket__'
 export const INTERCEPTOR_FUNCTION_NAME = '__interceptor__'

runtimes/nodejs/src/db.ts

@@ -9,7 +9,6 @@ import { MongoAccessor } from 'database-proxy'
 import Config from './config'
 import { createLogger, logger } from './support/logger'
 import * as mongodb_uri from 'mongodb-uri'
-import { FunctionCache } from './support/function-engine/cache'
 
 /**
  * Database Management
@@ -44,7 +43,6 @@ export class DatabaseAgent {
       .init()
       .then(async () => {
         logger.info('db connected')
-        FunctionCache.initialize()
       })
       .catch((error) => {
         logger.error(error)

runtimes/nodejs/src/index.ts

@@ -20,9 +20,16 @@ import xmlparser from 'express-xml-bodyparser'
 // init static method of class
 import './support/function-log'
 import './support/cloud-sdk'
+import { FunctionCache } from './support/function-engine/cache'
+import { DatabaseChangeStream } from './support/db-change-stream'
 
 const app = express()
 
+DatabaseAgent.accessor.ready.then(() => {
+  FunctionCache.initialize()
+  DatabaseChangeStream.initialize()
+})
+
 if (process.env.NODE_ENV === 'development') {
   app.use(cors())
 }

runtimes/nodejs/src/support/cloud-sdk.ts

@@ -26,7 +26,11 @@ function createCloudSdk() {
     },
     sockets: WebSocketAgent.clients,
     appid: Config.APP_ID,
-    env: process.env,
+    get env() {
+      return {
+        ...process.env,
+      }
+    },
   }
 
   /**

runtimes/nodejs/src/support/db-change-stream.ts

@@ -0,0 +1,41 @@
+import { CONFIG_COLLECTION } from '../constants'
+import { DatabaseAgent } from '../db'
+
+import { logger } from './logger'
+
+export class DatabaseChangeStream {
+  static async initialize() {
+    this.watchConf()
+  }
+
+  /**
+   * stream the change of cloud function
+   * @param
+   * @returns
+   */
+  static async watchConf() {
+    logger.info('Listening for changes in conf collection...')
+    this.updateEnvironments()
+
+    const stream = DatabaseAgent.db.collection(CONFIG_COLLECTION).watch()
+
+    stream.on('change', async (_change) => {
+      this.updateEnvironments()
+    })
+  }
+
+  private static async updateEnvironments() {
+    const conf = await DatabaseAgent.db
+      .collection(CONFIG_COLLECTION)
+      .findOne({})
+
+    if (!conf) {
+      return
+    }
+
+    const environments = conf.environments || []
+    for (const env of environments) {
+      process.env[env.name] = env.value
+    }
+  }
+}

runtimes/nodejs/src/support/function-engine/vm.ts

@@ -54,7 +54,9 @@ export class FunctionVm {
       clearInterval: clearInterval,
       setTimeout: setTimeout,
       clearTimeout: clearTimeout,
-      process: { env: process.env },
+      process: {
+        env: { ...process.env },
+      },
       URL: URL,
       fetch: globalThis.fetch,
       global: null,

server/src/application/configuration.service.ts

@@ -1,25 +1,37 @@
 import { Injectable, Logger } from '@nestjs/common'
+import { ApplicationConfiguration } from '@prisma/client'
+import { CN_PUBLISHED_CONF } from 'src/constants'
+import { DatabaseService } from 'src/database/database.service'
 import { PrismaService } from 'src/prisma/prisma.service'
 
 @Injectable()
 export class ApplicationConfigurationService {
   private readonly logger = new Logger(ApplicationConfigurationService.name)
 
-  constructor(private readonly prisma: PrismaService) {}
+  constructor(
+    private readonly prisma: PrismaService,
+    private readonly databaseService: DatabaseService,
+  ) {}
 
   async count(appid: string) {
-    return this.prisma.applicationConfiguration.count({
-      where: {
-        appid,
-      },
-    })
+    return this.prisma.applicationConfiguration.count({ where: { appid } })
   }
 
   async remove(appid: string) {
-    return this.prisma.applicationConfiguration.delete({
-      where: {
-        appid,
-      },
-    })
+    return this.prisma.applicationConfiguration.delete({ where: { appid } })
+  }
+
+  async publish(conf: ApplicationConfiguration) {
+    const { db, client } = await this.databaseService.findAndConnect(conf.appid)
+    const session = client.startSession()
+    try {
+      await session.withTransaction(async () => {
+        const coll = db.collection(CN_PUBLISHED_CONF)
+        await coll.deleteOne({ appid: conf.appid }, { session })
+        await coll.insertOne(conf, { session })
+      })
+    } finally {
+      await client.close()
+    }
   }
 }

server/src/application/environment.service.ts

@@ -1,19 +1,24 @@
 import { Injectable, Logger } from '@nestjs/common'
 import { PrismaService } from 'src/prisma/prisma.service'
 import { CreateEnvironmentDto } from './dto/create-env.dto'
+import { ApplicationConfigurationService } from './configuration.service'
 
 @Injectable()
 export class EnvironmentVariableService {
   private readonly logger = new Logger(EnvironmentVariableService.name)
 
-  constructor(private readonly prisma: PrismaService) {}
+  constructor(
+    private readonly prisma: PrismaService,
+    private readonly confService: ApplicationConfigurationService,
+  ) {}
 
   async updateAll(appid: string, dto: CreateEnvironmentDto[]) {
     const res = await this.prisma.applicationConfiguration.update({
       where: { appid },
       data: { environments: { set: dto } },
     })
 
+    await this.confService.publish(res)
     return res.environments
   }
 
@@ -37,6 +42,7 @@ export class EnvironmentVariableService {
       data: { environments: { set: origin } },
     })
 
+    await this.confService.publish(res)
     return res.environments
   }
 
@@ -54,6 +60,7 @@ export class EnvironmentVariableService {
       data: { environments: { deleteMany: { where: { name } } } },
     })
 
+    await this.confService.publish(res)
     return res
   }
 }

server/src/constants.ts

@@ -147,6 +147,7 @@ export const HTTP_METHODS = ['HEAD', 'GET', 'POST', 'PUT', 'DELETE', 'PATCH']
 export const CN_PUBLISHED_FUNCTIONS = '__functions__'
 export const CN_PUBLISHED_POLICIES = '__policies__'
 export const CN_FUNCTION_LOGS = '__function_logs__'
+export const CN_PUBLISHED_CONF = '__conf__'
 
 export const X_LAF_TRIGGER_TOKEN_KEY = 'x-laf-trigger-token'
 export const X_LAF_DEVELOP_TOKEN_KEY = 'x-laf-develop-token'