Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more app status process for release action #251

Merged

Conversation

moonrailgun
Copy link
Contributor

@moonrailgun moonrailgun commented Aug 11, 2022

  • add more app.status type. because backend cannot release starting/etc... status
    those request will return 400 response
    now disable it.
  • add new tooltip for disable case, tell user the reason of why we
    cannot release
  • add popconfirm for this action, its danger action, we should reconfirm it
  • allow created app delete

old

image

now

image

image

- add more `app.status` type. because backend cannot release `starting/etc...` status
  those request will return 422 response
  now disable it.
- add new tooltip for disable case, tell user the reason of why we
  cannot release
@maslow maslow merged commit dfed3e5 into labring:feat-web Aug 11, 2022
LeezQ pushed a commit to LeezQ/laf that referenced this pull request Sep 19, 2022
* feat: add more app status process for release action

- add more `app.status` type. because backend cannot release `starting/etc...` status
  those request will return 422 response
  now disable it.
- add new tooltip for disable case, tell user the reason of why we
  cannot release

* feat: add popconfirm for release app(its danger action)
LeezQ pushed a commit to LeezQ/laf that referenced this pull request Sep 28, 2022
* feat: add more app status process for release action

- add more `app.status` type. because backend cannot release `starting/etc...` status
  those request will return 422 response
  now disable it.
- add new tooltip for disable case, tell user the reason of why we
  cannot release

* feat: add popconfirm for release app(its danger action)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants