refactor(main): skip success exec (#4162) (#4170)

Co-authored-by: cuisongliu <cuisongliu@qq.com>
labring · Oct 26, 2023 · 6e89410 · 6e89410
1 parent 311213a
commit 6e89410
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/pkg/apply/applydrivers/apply_drivers_default.go b/pkg/apply/applydrivers/apply_drivers_default.go
@@ -166,7 +166,7 @@ func (c *Applier) updateStatus(clusterErr error, appErr error) {
 			cmdCondition = v2.NewFailedCommandCondition(appErr.Error())
 		}
 	} else if len(c.RunNewImages) > 0 {
-		cmdCondition = v2.NewSuccessCommandCondition()
+		return
 	}
 	cmdCondition.Images = c.RunNewImages
 	c.ClusterDesired.Status.CommandConditions = v2.UpdateCommandCondition(c.ClusterDesired.Status.CommandConditions, cmdCondition)

diff --git a/pkg/types/v1beta1/cluster.go b/pkg/types/v1beta1/cluster.go
@@ -172,16 +172,6 @@ type CommandCondition struct {
 	Message string `json:"message,omitempty"`
 }
 
-func NewSuccessCommandCondition() CommandCondition {
-	return CommandCondition{
-		Type:              CommandConditionTypeSuccess,
-		Status:            v1.ConditionTrue,
-		LastHeartbeatTime: metav1.Now(),
-		Reason:            "Apply Command",
-		Message:           "Applied to cluster successfully",
-	}
-}
-
 func NewFailedCommandCondition(message string) CommandCondition {
 	return CommandCondition{
 		Type:              CommandConditionTypeError,