Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase #3867 #4092

Merged
merged 13 commits into from
Oct 16, 2023
Merged

Rebase #3867 #4092

merged 13 commits into from
Oct 16, 2023

Conversation

bxy4543
Copy link
Member

@bxy4543 bxy4543 commented Oct 13, 2023

πŸ€– Generated by Copilot at b93cf4c

Summary

πŸ’ΈπŸ› οΈπŸŒ

This pull request implements the pay service, which provides APIs and handlers for creating and managing pay apps, payment methods, bills, and payment sessions. It also updates the go.work file, the go.work.sum file, and the GitHub workflow to include the new service and its dependencies. It creates and modifies files in the service/pay directory, such as Dockerfile, Makefile, go.mod, and .gitignore, as well as files in the api and handler packages. It adds a TODO comment to the account controller to address a potential issue with Stripe payments.

pay service is born
adding APIs and logic
autumn of payments

Walkthrough

  • Add a new pay service to the workspace and the GitHub workflow, which provides API endpoints and business logic for creating and managing pay apps, payment methods, payment sessions, and payment status. (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Add new dependencies for the workspace, such as github.com/cncf/xds/go, github.com/envoyproxy/go-control-plane, and github.com/envoyproxy/protoc-gen-validate, which may be used for implementing the xDS protocol and the Envoy proxy integration. (link, link, link, link)
  • Remove the unused dependency github.com/cespare/xxhash from the workspace. (link)
  • Modify the payment status constants in the pay package, changing the value of PaymentNotPaid and reordering the constants alphabetically. (link)
  • Add a TODO comment to the Reconcile function in the account controller, indicating the need to revise or replace the GetPaymentDetails function for Stripe payments. (link)

@bxy4543 bxy4543 requested a review from lingdie October 13, 2023 03:32
@sweep-ai
Copy link

sweep-ai bot commented Oct 13, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@pull-request-size
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Oct 13, 2023

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 956
βœ… Successful 371
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 580
❓ Unknown 0
🚫 Errors 4

Errors per input

Errors in docs/4.0/i18n/zh-Hans/examples/baas/install-fireboom.md

Errors in docs/4.0/docs/examples/baas/install-fireboom.md

Full action output

Full Github Actions output

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests βœ…

πŸ“’ Thoughts on this report? Let us know!.

geniuxy and others added 11 commits October 16, 2023 11:38
Signed-off-by: xy <2238384910@qq.com>
Signed-off-by: xy <2238384910@qq.com>
Signed-off-by: xy <2238384910@qq.com>
Signed-off-by: xy <2238384910@qq.com>
Signed-off-by: xy <2238384910@qq.com>
Signed-off-by: xy <2238384910@qq.com>
Signed-off-by: xy <2238384910@qq.com>
Signed-off-by: xy <2238384910@qq.com>
@bxy4543 bxy4543 added this to the v5.0 milestone Oct 16, 2023
@bxy4543 bxy4543 merged commit 4ad2acb into labring:main Oct 16, 2023
65 of 67 checks passed
@bxy4543 bxy4543 deleted the rebase_pay branch October 16, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants