feat: develop unified-pay api #3867

geniuxy · 2023-09-08T00:25:33Z

`🤖 Generated by Copilot at 7105fc9`

Summary

💰📝🐳

This pull request adds a new payment service to the sealos project, which can integrate with different payment methods, such as stripe and wechat, and provide various APIs for the clients to query and manage the payment details. It also updates the go.mod file to add a dependency for semantic versioning, and adds a TODO comment in the account_controller.go file to mark a known issue.

Sing, O Muse, of the mighty sealos project, the work of many hands
That strives to reconcile the accounts of users with various payment methods
And how they added to their code the payment service, service/pay
With many files and functions, like GetSession and CreatePayApp

Walkthrough

Add a new payment service that integrates with different payment methods (link, link, link, link, link, link, link, link, link, link, link, link, link, link)
- GetAppDetails: handles the request to get the payment details of a given app (link)
- GetBill: handles the request to get the bill details of a given user and app (link)
- CreatePayApp: handles the request to create a new pay app (link)
- CreatePayMethod: handles the request to create a new pay method (link)
- GetPayStatus: handles the request to get the payment status of a given session ID or order ID (link)
- GetSession: handles the request to get the session URL from different payment methods (link)
- conf: contains the code for the configuration of the payment service, which defines some common types and constants, such as the request struct, the database names, the payment methods, and the TLS certificates (link), and some functions for logging the HTTP requests and responses (link)
- helper: contains the code for the helper functions of the payment service, which query the database to get the payment details, bill details, and payment status (link, link)
- Dockerfile: defines the steps to build a Docker image for the payment service (link)
- go.mod: declares the module path, the Go version, and the required packages for the payment service (link)
- Makefile: defines the rules and commands to build, test, and deploy the payment service (link)
- .gitignore: specifies the patterns of files or directories that should be ignored by git (link)
Modify the account_controller.go file to add a TODO comment and copy the type definition of UserSpec (link, link)
- The TODO comment indicates that the Reconcile function has a problem when using stripe as the payment method, and suggests a possible solution by setting the stripe trade number as the session ID (link)
- The type definition of UserSpec is copied from the user_types.go file to make the account_controller.go file self-contained and avoid importing the user_types.go file (link)
Modify the go.mod file to add and remove a dependency (link, link)
- The dependency that is added is github.com/Masterminds/semver/v3, which is a package for parsing and comparing semantic versions (link)
- The dependency that is removed is github.com/Masterminds/semver/v3, which was marked as indirect and is not directly imported by the sealos code or any of its dependencies (link)
Modify the common.go file to change the constant values for the payment status (link)
- The change replaces the underscore with a lowercase letter in the values, such as not_paid to notpaid, to make them consistent with the values used by the payment methods (link)
Modify the go.work file to add a new directory to the workspace configuration (link)
- The directory that is added is ./service/pay, which contains the code for the payment service (link)
Modify the go.work.sum file to add and remove checksums for the packages required by the sealos project (link, link, link, link, link)
- The checksum that is removed is for the package github.com/cespare/xxhash, which is a fast hash function that is no longer used by the sealos code or any of its dependencies (link)
  - github.com/cncf/xds/go, which is a Go implementation of the xDS APIs for service discovery and configuration (link)
  - github.com/envoyproxy/go-control-plane, which is a Go library for building and consuming the xDS APIs (link)
  - github.com/envoyproxy/protoc-gen-validate, which is a protoc plugin to generate polyglot message validators (link)
  - google.golang.org/genproto and google.golang.org/genproto/googleapis/api, which are Go packages generated from protobuf files (link)

Signed-off-by: xy <2238384910@qq.com>

pull-request-size · 2023-09-08T00:25:40Z

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

sealos-ci-robot · 2023-09-08T00:26:01Z

🤖 Generated by lychee action

Summary

Status	Count
🔍 Total	932
✅ Successful	391
⏳ Timeouts	1
🔀 Redirected	0
👻 Excluded	539
❓ Unknown	0
🚫 Errors	0

Errors per input

Errors in README_zh.md

[TIMEOUT] https://www.oscs1024.com/project/labring/sealos?ref=badge_small | Timeout

Full action output

Full Github Actions output

codecov · 2023-09-08T00:43:12Z

Codecov Report

Patch has no changes to coverable lines.

❗ Current head 7d89c54 differs from pull request most recent head 9420c27. Consider uploading reports for the commit 9420c27 to get more accurate results

📢 Thoughts on this report? Let us know!.

dinoallo · 2023-09-08T03:45:48Z

service/pay/api/paymethod.go

+		return
+	}
+
+	c.AbortWithStatusJSON(http.StatusOK, gin.H{


Is there anything stopping you from using ctx.JSON to write to response body?

dinoallo · 2023-09-08T03:47:58Z

service/pay/conf/common.go

+// DB
+const (
+	DBURI              = "dburi"
+	Database           = "xy"


why would you hard-code this?

dinoallo · 2023-09-08T03:53:40Z

service/pay/helper/bill.go

@@ -0,0 +1,44 @@
+package helper


maybe rename this package to 'handler'

dinoallo · 2023-09-08T03:57:42Z

service/pay/helper/appdetail.go

+func GetAppDetails(request *conf.Request) ([]PMDetail, error) {
+	appID := request.AppID
+	filter := bson.D{{"appID", appID}}
+	appColl := InitDB(os.Getenv(conf.DBURI), conf.Database, conf.AppColl)


Do not initialize your database connections every time you receive your request and the handler gets called. First, it's huge resource waste since you don't reuse your database connections; Second, there will be noticeable response latency from the client side.

dinoallo · 2023-09-08T04:13:35Z

service/pay/helper/appdetail.go

+			return nil, fmt.Errorf("query error: %v", err)
+		}
+		// Iterate over the query results
+		for cursor.Next(context.TODO()) {


Use cursor.All(context.TODO(), documents)

dinoallo · 2023-09-08T04:16:56Z

service/pay/api/appdetail.go

+)
+
+func GetAppDetails(c *gin.Context) {
+	request, err := helper.Init(c)


Make this a gin middleware

Signed-off-by: xy <2238384910@qq.com>

* feat: develop unified-pay api Signed-off-by: xy <2238384910@qq.com> * feat: optimize unified-pay api Signed-off-by: xy <2238384910@qq.com> * feat: Translated some Chinese TODO Signed-off-by: xy <2238384910@qq.com> * fix some errors Signed-off-by: xy <2238384910@qq.com> * change encryption algorithm Signed-off-by: xy <2238384910@qq.com> * optimized code Signed-off-by: xy <2238384910@qq.com> * build gcr images Signed-off-by: xy <2238384910@qq.com> * fix bug and optimized code Signed-off-by: xy <2238384910@qq.com> * remove service/payment * fix cluster-image-build arm64 * build pay service cluter image * fix build service * fix package imports --------- Signed-off-by: xy <2238384910@qq.com> Co-authored-by: xy <2238384910@qq.com>

bxy4543 · 2023-10-16T06:46:44Z

#4092

sealos-ci-robot · 2023-10-16T06:46:55Z

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

#4092

feat: develop unified-pay api

7105fc9

Signed-off-by: xy <2238384910@qq.com>

pull-request-size bot added the size/XXL label Sep 8, 2023

sealos-ci-robot added area/cloud area/test area/lifecycle-management area/api labels Sep 8, 2023

Merge branch 'main' into pay

9e31267

sealos-ci-robot removed the area/api label Sep 8, 2023

dinoallo reviewed Sep 8, 2023

View reviewed changes

geniuxy added 7 commits September 8, 2023 20:51

feat: optimize unified-pay api

a202e95

Signed-off-by: xy <2238384910@qq.com>

Merge remote-tracking branch 'origin/pay' into pay

d692294

feat: Translated some Chinese TODO

9fd4843

Signed-off-by: xy <2238384910@qq.com>

fix some errors

4220e1d

Signed-off-by: xy <2238384910@qq.com>

change encryption algorithm

0446569

Signed-off-by: xy <2238384910@qq.com>

optimized code

7d89c54

Signed-off-by: xy <2238384910@qq.com>

build gcr images

2dcab22

Signed-off-by: xy <2238384910@qq.com>

sealos-ci-robot added the area/workflow label Sep 19, 2023

fix bug and optimized code

9420c27

Signed-off-by: xy <2238384910@qq.com>

bxy4543 closed this Oct 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: develop unified-pay api #3867

feat: develop unified-pay api #3867

geniuxy commented Sep 8, 2023 •

edited by ghost

Loading

pull-request-size bot commented Sep 8, 2023

sealos-ci-robot commented Sep 8, 2023 •

edited

Loading

codecov bot commented Sep 8, 2023 •

edited

Loading

dinoallo Sep 8, 2023

dinoallo Sep 8, 2023

dinoallo Sep 8, 2023

geniuxy Sep 8, 2023

dinoallo Sep 8, 2023

dinoallo Sep 8, 2023 •

edited

Loading

dinoallo Sep 8, 2023

bxy4543 commented Oct 16, 2023

sealos-ci-robot commented Oct 16, 2023

feat: develop unified-pay api #3867

feat: develop unified-pay api #3867

Conversation

geniuxy commented Sep 8, 2023 • edited by ghost Loading

🤖 Generated by Copilot at 7105fc9

Summary

Walkthrough

pull-request-size bot commented Sep 8, 2023

Whoa! Easy there, Partner!

sealos-ci-robot commented Sep 8, 2023 • edited Loading

🤖 Generated by lychee action

Summary

Errors per input

Errors in README_zh.md

Full action output

codecov bot commented Sep 8, 2023 • edited Loading

Codecov Report

dinoallo Sep 8, 2023

Choose a reason for hiding this comment

dinoallo Sep 8, 2023

Choose a reason for hiding this comment

dinoallo Sep 8, 2023

Choose a reason for hiding this comment

geniuxy Sep 8, 2023

Choose a reason for hiding this comment

dinoallo Sep 8, 2023

Choose a reason for hiding this comment

dinoallo Sep 8, 2023 • edited Loading

Choose a reason for hiding this comment

dinoallo Sep 8, 2023

Choose a reason for hiding this comment

bxy4543 commented Oct 16, 2023

sealos-ci-robot commented Oct 16, 2023

geniuxy commented Sep 8, 2023 •

edited by ghost

Loading

`🤖 Generated by Copilot at 7105fc9`

sealos-ci-robot commented Sep 8, 2023 •

edited

Loading

codecov bot commented Sep 8, 2023 •

edited

Loading

dinoallo Sep 8, 2023 •

edited

Loading