-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(main): sync cert for cert cmd #3891
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 11, 2023
🤖 Generated by lychee actionSummary
Full action output |
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
Signed-off-by: cuisongliu <cuisongliu@qq.com>
cuisongliu
force-pushed
the
sync_cert
branch
from
September 15, 2023 07:45
247f7df
to
b176266
Compare
tested |
zzjin
approved these changes
Sep 18, 2023
/cherry-pick release-v4.4 |
🤖 says: cherry pick action finished successfully 🎉! |
sealos-ci-robot
pushed a commit
that referenced
this pull request
Sep 18, 2023
Signed-off-by: cuisongliu <cuisongliu@qq.com>
cuisongliu
added a commit
that referenced
this pull request
Sep 18, 2023
bxy4543
pushed a commit
to bxy4543/sealos
that referenced
this pull request
Oct 13, 2023
Signed-off-by: cuisongliu <cuisongliu@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 247f7df
Summary
🐛🔄🔐
Fix certificate and kubeconfig synchronization bug for master nodes. Refactor
pkg/runtime/kubernetes/certs.go
to use a new functionk.syncCert
that generates and copies certificates and kubeconfigs for all master nodes.Walkthrough
k.syncCert
to synchronize the certificates and kubeconfigs of all the master nodes after adding a new SAN to the API server certificate (link inpkg/runtime/kubernetes/certs.go
)