Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(costcenter): transfer error #4010

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

xudaotutou
Copy link
Contributor

@xudaotutou xudaotutou commented Sep 27, 2023

πŸ€– Generated by Copilot at 8892a4f

Summary

πŸššπŸ› οΈπŸ§Ή

This pull request refactors and improves the code for handling payment and billing requests in the costcenter provider. It uses a common function GetUserDefaultNameSpace to get the user's default namespace, and removes or adds the kube_namespace variable as needed. It also moves some code from transfer.ts to pay.ts and fixes some minor errors.

pay.ts refactored
kube_namespace removed
code is more concise

Walkthrough

  • Simplify and unify the logic for getting the user's default namespace by using the GetUserDefaultNameSpace function (link, link, link, link, link, link)
  • Move the code for creating a transfer CRD from transfer.ts to pay.ts and delete the unused transfer.ts file (link)
  • Add the missing import of the GetUserDefaultNameSpace function to the files that use it (link, link)

@sealos-ci-robot
Copy link
Member

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 973
βœ… Successful 400
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 572
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@lingdie lingdie merged commit cd43d4b into labring:main Sep 27, 2023
bxy4543 pushed a commit to bxy4543/sealos that referenced this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants