Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Automated CherryPick Update for release-v4.4 #4022

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

sealos-ci-robot
Copy link
Member

@sealos-ci-robot sealos-ci-robot commented Sep 29, 2023

πŸ€– Generated by Copilot at 657b8d2

Summary

πŸ‘πŸ—‘οΈπŸšͺ

This pull request improves the node deletion and management logic for k3s clusters in sealos. It uses a new function removeNodes to properly remove nodes from the cluster and handles node IP and port changes in k3s.go and reset.go.

Oh, we're the sealos crew and we know what to do
When we need to reset or remove a node or two
We use GetNodeIPAndPortList and removeNodes too
And we keep our k3s cluster running smooth and true

Walkthrough

  • Replace resetNodes with removeNodes for scaling down k3s clusters (link, link)
  • Add removeNodes function to lifecycle.go to implement node removal logic (link)
  • Modify resetNode and deleteNode functions in lifecycle.go to handle node IP and port list and master node deletion (link, link)
  • Modify resetNode function in reset.go to use GetNodeIPAndPortList instead of GetNodeIPList for checking if the node is part of the cluster (link)

Automated changes by create-pull-request GitHub action

* feature(main): reset cluster not delete nodes

Signed-off-by: cuisongliu <cuisongliu@qq.com>

* feature(main): reset cluster not delete nodes

Signed-off-by: cuisongliu <cuisongliu@qq.com>
(cherry picked from commit 6fc0bea)

---------

Signed-off-by: cuisongliu <cuisongliu@qq.com>
@cuisongliu cuisongliu added this to the cherry-pick milestone Sep 29, 2023
@cuisongliu cuisongliu merged commit 3f4d100 into release-v4.4 Sep 29, 2023
85 checks passed
@cuisongliu cuisongliu deleted the cherry-pick-release-v4.4-3991 branch September 29, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants