Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(main): using sreg 0.1.4 build image (#4023) #4028

Merged

Conversation

cuisongliu
Copy link
Collaborator

@cuisongliu cuisongliu commented Oct 7, 2023

(cherry picked from commit 3c8c639)

πŸ€– Generated by Copilot at 71d39fd

Summary

πŸ“„πŸ–ŠοΈπŸ†™

This pull request adds support for building images from tar packages and image lists with sealos. It also updates the documentation and the dependency of github.com/labring/sreg.

Sing, O Muse, of the skillful builders of images
Who with sealos and buildah craft their wondrous works
From lists and tar packages they shape the forms of clusters
And applications, like Hephaestus at his forge

Walkthrough

  • Add a new document build-image-image-list.md to explain how to use image lists or tar packages to build images with sealos (link)
  • Update the link text in build.md to match the terminology in build-image-image-list.md (link)
  • Update the version of the github.com/labring/sreg dependency in go.mod to use the latest features and bug fixes (link)
  • Add the checksum of the github.com/labring/sreg dependency in go.work.sum to ensure the integrity of the dependencies (link)
  • Modify the runSaveImages function in pkg/buildah/imagesaver.go to support saving images from tar packages and handle different types of images separately (link, link)
  • Delete the file build-image-image_list.md (link)

Signed-off-by: cuisongliu <cuisongliu@qq.com>

(cherry picked from commit 3c8c639)
Signed-off-by: cuisongliu <cuisongliu@qq.com>
@cuisongliu cuisongliu added this to the v4.3 milestone Oct 7, 2023
@cuisongliu cuisongliu linked an issue Oct 7, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

All modified lines are covered by tests βœ…

πŸ“’ Thoughts on this report? Let us know!.

@sealos-ci-robot sealos-ci-robot merged commit 13b3036 into labring:release-v4.4 Oct 7, 2023
39 checks passed
@sealos-ci-robot sealos-ci-robot deleted the release-v4.4-sreg1.0.4 branch October 7, 2023 03:06
@sealos-ci-robot
Copy link
Member

/cherry-pick release-v4.3

@sealos-ci-robot
Copy link
Member

πŸ€– says: cherry pick action finished successfully πŸŽ‰!
See: https://github.com/labring/sealos/actions/runs/6438674943

sealos-ci-robot pushed a commit that referenced this pull request Oct 7, 2023
(cherry picked from commit 3c8c639)

Signed-off-by: cuisongliu <cuisongliu@qq.com>
cuisongliu added a commit that referenced this pull request Oct 7, 2023
(cherry picked from commit 3c8c639)

Signed-off-by: cuisongliu <cuisongliu@qq.com>
Co-authored-by: cuisongliu <cuisongliu@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error cherry-picking PR #4023
2 participants