Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:modify the format of the exported file #4040

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Conversation

zjy365
Copy link
Contributor

@zjy365 zjy365 commented Oct 7, 2023

🤖 Generated by Copilot at 3b2b8c2

Summary

📄🐛🆕

This pull request modifies the frontend code of several providers to export a single YAML file instead of a ZIP file when exporting templates or applications. This simplifies the export process and removes the dependency on JSZip. It also adds support for the new template type attribute in the backend and fixes a bug in the cronjob provider.

We're sailing on the code sea, me hearties
We're exporting YAML files with ease
We've fixed some bugs and added some features
We're pulling and pushing on the count of three

Walkthrough

  • Simplified the export process of YAML files by removing the dependency on JSZip and exporting a single YAML file instead of a ZIP file containing multiple YAML files (link, link, link)
  • Fixed a bug in the getUserServiceAccount function in the user.ts file by returning the user field from the context object instead of the namespace field (link)
  • Added the template_type field to the TemplateType type definition in the app.ts file and the handleTemplateToInstanceYaml function in the json-yaml.ts file to support the new template type attribute that was introduced in the backend (link, link, link)
  • Improved the user experience by providing sensible defaults for the template inputs using the defaultInputes variable and the generateCorrectYaml function in the index.tsx file (link)
  • Moved the > character to the previous line in several files to follow the code style convention of the project (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)

Signed-off-by: jingyang <3161362058@qq.com>
@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 976
✅ Successful 403
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 572
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@zzjin zzjin added this to the v5.0 milestone Oct 7, 2023
@zzjin zzjin merged commit 4cbb449 into labring:main Oct 7, 2023
28 checks passed
bxy4543 pushed a commit to bxy4543/sealos that referenced this pull request Oct 13, 2023
Signed-off-by: jingyang <3161362058@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants