Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app template draft spec. #4044

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Add app template draft spec. #4044

merged 1 commit into from
Oct 8, 2023

Conversation

zzjin
Copy link
Collaborator

@zzjin zzjin commented Oct 8, 2023

πŸ€– Generated by Copilot at 1ebe059

Summary

βœοΈπŸ·οΈπŸ”§

Added a draft property to the Template and Instance resources and their corresponding CRDs. This property allows marking templates and instances as drafts, which can affect their deployment logic.

Draft field is new
Mark templates and instances
Autumn leaves falling

Walkthrough

  • Add draft field to TemplateData struct to indicate draft status of templates (link)
  • Add draft property to spec schema of Template and Instance CRDs to correspond to TemplateData field (link, link)
  • Add draft property to spec schema of Template and Instance resources in deploy.yaml file to mark them as drafts or not (link, link)

Signed-off-by: zzjin <tczzjin@gmail.com>
@sealos-ci-robot
Copy link
Member

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 976
βœ… Successful 403
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 572
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

All modified lines are covered by tests βœ…

πŸ“’ Thoughts on this report? Let us know!.

@zzjin zzjin merged commit de95395 into labring:main Oct 8, 2023
42 checks passed
bxy4543 pushed a commit to bxy4543/sealos that referenced this pull request Oct 13, 2023
Signed-off-by: zzjin <tczzjin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants