Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: if string addr has not colon #4045

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix: if string addr has not colon #4045

merged 1 commit into from
Oct 9, 2023

Conversation

fengxsong
Copy link
Collaborator

@fengxsong fengxsong commented Oct 9, 2023 •
edited by ghost
Loading

🤖 Generated by Copilot at 1583a8d

Summary

📦🛠️🚀

Improved host IP detection in isLocal function. Added iputils package and handled various address formats in pkg/exec/exec.go.

iputils is the key to our salvation
We can parse any address in creation
No more errors in our isLocal function
We are the masters of network detection

Walkthrough

  • Import iputils package to use GetHostIP function for extracting host IP from address strings (link)
  • Refactor isLocal function to use GetHostIP instead of net.SplitHostPort for more robust and consistent address parsing (link)

@fengxsong
fix: if string addr has not colon
1583a8d 
Signed-off-by: fengxsong <fengxsong@outlook.com>
@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 976
✅ Successful 403
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 572
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@cuisongliu cuisongliu added this to the v4.4 milestone Oct 9, 2023
@cuisongliu cuisongliu merged commit 25e08fd into labring:main Oct 9, 2023
69 checks passed
@fengxsong fengxsong deleted the fix_islocal branch October 9, 2023 02:35
@sealos-ci-robot
Copy link
Member

/cherry-pick release-v4.4

@sealos-ci-robot
Copy link
Member

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/labring/sealos/actions/runs/6451742519

sealos-ci-robot pushed a commit that referenced this pull request Oct 9, 2023
@fengxsong
fix: if string addr has not colon (#4045)
f09f754 
Signed-off-by: fengxsong <fengxsong@outlook.com>
cuisongliu pushed a commit that referenced this pull request Oct 9, 2023
@sealos-ci-robot @fengxsong
fix: if string addr has not colon (#4045) (#4046)
105a74c 
Signed-off-by: fengxsong <fengxsong@outlook.com>
Co-authored-by: fengxsong <fengxsong@outlook.com>
This was referenced Oct 9, 2023
Merged
Closed
bxy4543 pushed a commit to bxy4543/sealos that referenced this pull request Oct 13, 2023
@fengxsong @bxy4543
fix: if string addr has not colon (labring#4045)
bff02c7 
Signed-off-by: fengxsong <fengxsong@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuisongliu cuisongliu cuisongliu approved these changes

Assignees
No one assigned
Labels
area/lifecycle-management size/XS
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@fengxsong @sealos-ci-robot @cuisongliu