Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/cloud init scripts #4084

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Fix/cloud init scripts #4084

merged 5 commits into from
Oct 16, 2023

Conversation

bxy4543
Copy link
Member

@bxy4543 bxy4543 commented Oct 12, 2023 •
edited by ghost
Loading

πŸ€– Generated by Copilot at 89fc6f3

Summary

πŸ–ΌοΈπŸš€β³

This pull request enhances the cloud installation and deployment features of sealos. It adds MongoDB 5.0 and AVX support, a metrics-server component, and a waiting animation to scripts/cloud/install.sh. It also switches to svg icons for better scalability in frontend/providers/costcenter/deploy/manifests/appcr.yaml.tmpl.

This pull request has quite a lot
From icon.svg to metrics-server pod
It supports MongoDB five
And AVX to thrive
And a waiting animation that's not a dot

Walkthrough

  • Change icon file extension to svg for better scalability (link)
  • Add variable mongodbVersion to store default MongoDB version (link)
  • Replace precheck function with setMongoVersion function to check CPU AVX support and set mongodbVersion accordingly (link)
  • Pass mongodbVersion as environment variable to sealos-cloud component to deploy MongoDB service (link)
  • Add metrics-server component to provide resource metrics for the cluster (link)
  • Add prompt message to allow user to skip waiting for cluster to be ready by entering '1' (link, link)
  • Add wait_cluster_ready function to use loading animation and loop to check cluster nodes status (link)
  • Modify echo command for displaying cloud login info to use conditional expansion for cloud port (link)

@bxy4543
fix incorrect colon display;
4c61783 
optimize：if avx is not supported, select the lower version of mongo;
check cluster ready, can skip;
fix costcenter app logo;
add metrics server;
@bxy4543
optimize
89fc6f3
@bxy4543 bxy4543 requested a review from lingdie October 12, 2023 08:35
@sweep-ai
Copy link

sweep-ai bot commented Oct 12, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Oct 12, 2023 •
edited
Loading

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 948
βœ… Successful 369
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 578
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests βœ…

see 1 file with indirect coverage changes

πŸ“’ Thoughts on this report? Let us know!.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 12, 2023
@bxy4543 bxy4543 added this to the v5.0 milestone Oct 13, 2023
@lingdie lingdie merged commit 513162a into labring:main Oct 16, 2023
47 of 48 checks passed
@bxy4543 bxy4543 deleted the fix/cloud_init_scripts branch October 18, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lingdie lingdie lingdie approved these changes

Assignees
No one assigned
Labels
area/ci area/frontend size/L
Projects
None yet
Milestone
v5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bxy4543 @sealos-ci-robot @lingdie