Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor license #4086

Closed
wants to merge 5 commits into from
Closed

refactor license #4086

wants to merge 5 commits into from

Conversation

lingdie
Copy link
Collaborator

@lingdie lingdie commented Oct 12, 2023

πŸ€– Generated by Copilot at 8230111

Summary

πŸššπŸ› οΈπŸ†•

Renamed and refactored the licenseissuer controller to license, and changed the API group name to license.sealos.io. Added new binaries and files for the launcher and preset functionality, and updated the CRD definition and kustomization files. Added a Dockerfile and a PROJECT file for the license controller.

We're changing the name of the licenseissuer today
From infostream to license we'll sail away
Heave ho, me hearties, on the count of three
We'll update the CRD and the API

Walkthrough

  • Rename licenseissuer controller to license and update API group to license.sealos.io (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Add Type field to LicenseSpec and Phase field to LicenseStatus (link, link)
  • Remove Launcher, LauncherList, LauncherSpec, and LauncherStatus types from license API (link)
  • Add main.go files for launcher and preset binaries with TODO comments (link, link)
  • Simplify manager main.go file and remove unused imports and code (link, link, link, link, link, link, link)
  • Add Dockerfile for license controller with multi-stage build and arguments (link)
  • Add PROJECT file with kubebuilder metadata and configuration (link)
  • Update controller-gen version and kustomize syntax in CRD files (link, link)
  • Change namespace to license-system and enable cert-manager annotation patch (link, link)
  • Update kube-rbac-proxy image version and remove nodeAffinity (link, link)
  • Add .vscode to .gitignore file (link)
  • Change bin directory to bin/* in .gitignore file (link)
  • Change LD_FLAGS to use util package for license key (link)
  • Add TODO comment for overview in README.md file (link)

@sweep-ai
Copy link

sweep-ai bot commented Oct 12, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@pull-request-size
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

@lingdie lingdie added this to the v5.0 milestone Oct 12, 2023
@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Oct 12, 2023

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 948
βœ… Successful 369
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 578
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Ξ”
pkg/apply/gen.go 38.46% <0.00%> (-0.76%) ⬇️

πŸ“’ Thoughts on this report? Let us know!.

@lingdie lingdie closed this Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants