Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete license issuer. #4101

Merged
merged 1 commit into from
Oct 16, 2023
Merged

delete license issuer. #4101

merged 1 commit into from
Oct 16, 2023

Conversation

lingdie
Copy link
Collaborator

@lingdie lingdie commented Oct 16, 2023

πŸ€– Generated by Copilot at fed59d5

Summary

πŸ—‘οΈβ™»οΈπŸ“¦

Remove licenseissuer controller from sealos workflow and project. This controller is now maintained in a separate repository.

There once was a controller named licenseissuer
That used to be part of the sealos cluster
But it was deprecated
And then separated
Now it lives in its own repo with less fuss and bluster

Walkthrough

  • Remove licenseissuer controller from the workflow and the cluster (link, link)
  • Delete all files related to the licenseissuer controller, including the API types, the main logic, the Dockerfile, the Makefile, the README, the configuration files, and the generated files (link-link)

@pull-request-size
Copy link

Whoa! Easy there, Partner!

This PR is too big. Please break it up into smaller PRs.

@sealos-ci-robot
Copy link
Member

πŸ€– Generated by lychee action

Summary

Status Count
πŸ” Total 952
βœ… Successful 371
⏳ Timeouts 0
πŸ”€ Redirected 0
πŸ‘» Excluded 580
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@sweep-ai
Copy link

sweep-ai bot commented Oct 16, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@zzjin zzjin added this to the v5.0 milestone Oct 16, 2023
@lingdie lingdie merged commit c4f1da2 into labring:main Oct 16, 2023
71 checks passed
@lingdie lingdie deleted the license-delete branch October 16, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants