Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mv cmd/pkg to booter #4102

Closed
wants to merge 6 commits into from
Closed

mv cmd/pkg to booter #4102

wants to merge 6 commits into from

Conversation

lingdie
Copy link
Collaborator

@lingdie lingdie commented Oct 16, 2023

🤖 Generated by Copilot at 5d20444

Summary

📱🌐🛒

Move all command-line interface (CLI) related files from cmd to cli directory. This is to improve the project structure and avoid confusion with the cmd package in the standard library.

is_valid checks
refactored and improved
autumn of bugs ends

Walkthrough

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Oct 16, 2023

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 956
✅ Successful 375
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 580
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@sweep-ai
Copy link

sweep-ai bot commented Oct 16, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@lingdie lingdie requested review from zzjin and cuisongliu October 16, 2023 08:57
@lingdie lingdie changed the title mv cmd/pkg to cli mv cmd/pkg to booter Oct 18, 2023
@zzjin zzjin added this to the v4.4 milestone Oct 21, 2023
@cuisongliu cuisongliu marked this pull request as draft October 23, 2023 04:52
Signed-off-by: yy <lingdie.yy@outlook.com>
@cuisongliu cuisongliu modified the milestones: v4.4, v5.0 Dec 10, 2023
@lingdie lingdie closed this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants