Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 set default http sync registry #4120

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

cuisongliu
Copy link
Collaborator

@cuisongliu cuisongliu commented Oct 19, 2023

Signed-off-by: cuisongliu cuisongliu@qq.com

Conflicts:

pkg/filesystem/registry/sync.go

🤖 Generated by Copilot at 64b1f2f

Summary

🛠️🐛🚀

This pull request adds a debug mode to the registry serve command and fixes a path issue in the syncViaSSH function. These changes help users to troubleshoot and manage the registry service for sealos.

Sing, O Muse, of the valiant deeds of sealos,
The mighty tool that builds and manages clusters,
How it enhanced its registry serve command
With a debug mode, a boon for troubleshooters.

Walkthrough

  • Enable debug mode for registry server by adding -d flag to registry serve command (link)
  • Fix bug in syncViaSSH function by using correct path for remote registry directory from RootFSRegistryPath method (link)

@sweep-ai
Copy link

sweep-ai bot commented Oct 19, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

Signed-off-by: cuisongliu <cuisongliu@qq.com>

# Conflicts:
#	pkg/filesystem/registry/sync.go
@cuisongliu cuisongliu added this to the cherry-pick milestone Oct 20, 2023
@cuisongliu cuisongliu merged commit a271984 into labring:release-v4.3 Oct 20, 2023
68 checks passed
@cuisongliu cuisongliu deleted the http-sync branch October 20, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment